Minor updates to i18n strings for clarity and consistency#2705
Merged
tdonohue merged 4 commits intoDSpace:mainfrom Feb 7, 2024
Merged
Minor updates to i18n strings for clarity and consistency#2705tdonohue merged 4 commits intoDSpace:mainfrom
tdonohue merged 4 commits intoDSpace:mainfrom
Conversation
Reviewer is a less obscure term for what this actually is in most cases.
We should be capitalizing acronyms and project-specific nouns like MyDSpace consistently in our interface.
Fix some random capitalizations and strange wording.
alanorth
added
i18n / l10n
alanorth
added a commit
to ilri/dspace-angular
that referenced
this pull request
Dec 8, 2023
- change "controller" to "reviewer" - capitalize acronyms and project-specific nouns like MyDSpace consistently in our interface. - fix some random capitalizations and strange wording. Temporary until upstream patch is merged. See: DSpace#2705
alanorth
added a commit
to ilri/dspace-angular
that referenced
this pull request
Jan 12, 2024
- change "controller" to "reviewer" - capitalize acronyms and project-specific nouns like MyDSpace consistently in our interface. - fix some random capitalizations and strange wording. Temporary until upstream patch is merged. See: DSpace#2705
alanorth
added a commit
to ilri/dspace-angular
that referenced
this pull request
Jan 23, 2024
- change "controller" to "reviewer" - capitalize acronyms and project-specific nouns like MyDSpace consistently in our interface. - fix some random capitalizations and strange wording. Temporary until upstream patch is merged. See: DSpace#2705
alanorth
added a commit
to ilri/dspace-angular
that referenced
this pull request
Jan 26, 2024
- change "controller" to "reviewer" - capitalize acronyms and project-specific nouns like MyDSpace consistently in our interface. - fix some random capitalizations and strange wording. Temporary until upstream patch is merged. See: DSpace#2705
alanorth
added a commit
to ilri/dspace-angular
that referenced
this pull request
Feb 4, 2024
- change "controller" to "reviewer" - capitalize acronyms and project-specific nouns like MyDSpace consistently in our interface. - fix some random capitalizations and strange wording. Temporary until upstream patch is merged. See: DSpace#2705
alanorth
added a commit
to ilri/dspace-angular
that referenced
this pull request
Feb 6, 2024
- change "controller" to "reviewer" - capitalize acronyms and project-specific nouns like MyDSpace consistently in our interface. - fix some random capitalizations and strange wording. Temporary until upstream patch is merged. See: DSpace#2705
Contributor
|
Successfully created backport PR for |
tdonohue
removed
the
port to dspace-7_x
4science-it
pushed a commit
to 4Science/dspace-angular
that referenced
this pull request
Feb 3, 2025
…Space#2705) [DSC-1957_fix-font] Approved-by: Giuseppe Digilio
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Minor updates to i18n strings for clarity and consistency. For example:
"mydspace.status.mydspaceWaitingController": "Waiting for controller"— what is a "controller"?After some discussion on Slack we decided that "reviewer" is more clear than "controller".
As well as some others:
"mydspace.results.no-uri": "No Uri"— URI is an acronym and should be capitalized"mydspace.search-form.placeholder": "Search in mydspace..."— lower case mysdspace"mydspace.title": "MyDSpace"— camel case MyDSpace"nav.user-profile-menu-and-logout": "User profile menu and Log Out"— why is "Log Out" capitalized?emailinstead ofe-mailbecause there were 61 occurrences of the former and only seven of the latter, ande-mailseems antiquatedInstructions for Reviewers
Build the application and check if the user interface has updated strings. Most importantly, check the status filter in the workflow to make sure the new "Waiting for reviewer" strings and labels work correctly.
List of changes in this PR:
Checklist
yarn lintyarn check-circ-deps)package.json), I've made sure their licenses align with the DSpace BSD License based on the Licensing of Contributions documentation.