site search should not adopt existing URL query string parameters#2818
Merged
alanorth merged 2 commits intoDSpace:mainfrom Feb 22, 2024
Merged
site search should not adopt existing URL query string parameters#2818alanorth merged 2 commits intoDSpace:mainfrom
alanorth merged 2 commits intoDSpace:mainfrom
Conversation
saschaszott
changed the title
tdonohue
added
bug
component: Discovery
Contributor
|
Thanks @saschaszott! I confirmed the bug and the fix on DSpace 7.6.1. I will squash these two commits into one before merging because the second one fixes a test broken by the first and this can easily be one atomic change. |
alanorth
approved these changes
Feb 22, 2024
Contributor
|
Successfully created backport PR for |
alanorth
removed
the
port to dspace-7_x
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
A site search (issued by the search box in the navigation bar) should not adopt existing URL query parameters. For example, a site search that is issued in the context of MyDSpace will adopt
configuration=workspaceas a URL query parameter.The normal user would not expect that a site search considers only a subset of all items in the repository. It is commonly expected that a site search behaves consistent regardless of the context from which the search was started.