Skip to content

Live import preview should show all metadata values, not only the first one#2954

Merged
tdonohue merged 3 commits intoDSpace:mainfrom
atmire:w2p-104686_Live-import-preview-only-shows-first-mdv-7.6
May 10, 2024
Merged

Live import preview should show all metadata values, not only the first one#2954
tdonohue merged 3 commits intoDSpace:mainfrom
atmire:w2p-104686_Live-import-preview-only-shows-first-mdv-7.6

Conversation

@jensvannerum
Copy link
Copy Markdown
Contributor

Description

This change makes is to the live import preview shows all metadata values present, not only the first one.
This gives user a better idea of the item they are actually importing.

Instructions for Reviewers

This simply changes the single metadataValue object to a list of them and displays them with an ngFor

You can test this by:

  • going to /mydspace
  • selecting an external item for import
  • open up the preview, verify you can see multiple values for the metadata fields (if present)

Checklist

  • My PR is small in size (e.g. less than 1,000 lines of code, not including comments & specs/tests), or I have provided reasons as to why that's not possible.
  • My PR passes ESLint validation using yarn lint
  • My PR doesn't introduce circular dependencies (verified via yarn check-circ-deps)
  • My PR includes TypeDoc comments for all new (or modified) public methods and classes. It also includes TypeDoc for large or complex private methods.
  • My PR passes all specs/tests and includes new/updated specs or tests based on the Code Testing Guide.
  • If my PR includes new libraries/dependencies (in package.json), I've made sure their licenses align with the DSpace BSD License based on the Licensing of Contributions documentation.
  • If my PR includes new features or configurations, I've provided basic technical documentation in the PR itself.
  • If my PR fixes an issue ticket, I've linked them together.

@tdonohue tdonohue added bug 1 APPROVAL pull request only requires a single approval to merge tools:import-sources Related to "Live Import" Sources feature, allowing import of content via external APIs. port to dspace-7_x This PR needs to be ported to `dspace-7_x` branch for next bug-fix release labels Apr 18, 2024
@tdonohue tdonohue added this to the 8.0 milestone Apr 18, 2024
Copy link
Copy Markdown
Member

@tdonohue tdonohue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Thanks @jensvannerum ! I was able to verify the bug by trying some imports from MyDSpace via PubMed and noticing that only one author is always shown in the preview. Once I installed this PR, I can see the entire author list.

@tdonohue tdonohue merged commit 8b1f46c into DSpace:main May 10, 2024
@dspace-bot
Copy link
Copy Markdown
Contributor

Backport failed for dspace-7_x, because it was unable to cherry-pick the commit(s).

Please cherry-pick the changes locally and resolve any conflicts.

git fetch origin dspace-7_x
git worktree add -d .worktree/backport-2954-to-dspace-7_x origin/dspace-7_x
cd .worktree/backport-2954-to-dspace-7_x
git switch --create backport-2954-to-dspace-7_x
git cherry-pick -x 00d7b8322d38fe007e3f7b19db6716ff206113cb 5f89dd27fbd3ce11d48b0b9ec0d693e42727d909

@tdonohue
Copy link
Copy Markdown
Member

Manually ported to 7.x in #3034

@tdonohue tdonohue removed the port to dspace-7_x This PR needs to be ported to `dspace-7_x` branch for next bug-fix release label May 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

1 APPROVAL pull request only requires a single approval to merge bug tools:import-sources Related to "Live Import" Sources feature, allowing import of content via external APIs.

Projects

No open projects
Status: ✅ Done

Development

Successfully merging this pull request may close these issues.

4 participants