Live import preview should show all metadata values, not only the first one#2954
Merged
tdonohue merged 3 commits intoDSpace:mainfrom May 10, 2024
Conversation
…ort-preview-only-shows-first-mdv-7.6
tdonohue
approved these changes
May 10, 2024
Member
tdonohue
left a comment
There was a problem hiding this comment.
👍 Thanks @jensvannerum ! I was able to verify the bug by trying some imports from MyDSpace via PubMed and noticing that only one author is always shown in the preview. Once I installed this PR, I can see the entire author list.
Contributor
|
Backport failed for Please cherry-pick the changes locally and resolve any conflicts. git fetch origin dspace-7_x
git worktree add -d .worktree/backport-2954-to-dspace-7_x origin/dspace-7_x
cd .worktree/backport-2954-to-dspace-7_x
git switch --create backport-2954-to-dspace-7_x
git cherry-pick -x 00d7b8322d38fe007e3f7b19db6716ff206113cb 5f89dd27fbd3ce11d48b0b9ec0d693e42727d909 |
Member
|
Manually ported to 7.x in #3034 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This change makes is to the live import preview shows all metadata values present, not only the first one.
This gives user a better idea of the item they are actually importing.
Instructions for Reviewers
This simply changes the single metadataValue object to a list of them and displays them with an ngFor
You can test this by:
Checklist
yarn lintyarn check-circ-deps)package.json), I've made sure their licenses align with the DSpace BSD License based on the Licensing of Contributions documentation.