[Port dspace-7_x] Fixed pagination issues on item mapper#2968
Merged
tdonohue merged 5 commits intoDSpace:dspace-7_xfrom Apr 22, 2024
Merged
Conversation
…ll the components gave the incorrect type of data to it
…me changes are detected
…ery time changes are detected
…dspace-7_x # Conflicts: # src/app/access-control/bulk-access/browse/bulk-access-browse.component.html # src/app/access-control/epeople-registry/epeople-registry.component.html # src/app/access-control/epeople-registry/eperson-form/eperson-form.component.html # src/app/access-control/group-registry/group-form/members-list/members-list.component.html # src/app/access-control/group-registry/group-form/subgroup-list/subgroups-list.component.html # src/app/shared/object-select/collection-select/collection-select.component.html # src/app/shared/object-select/item-select/item-select.component.html
alexandrevryghem
added
bug
component: Discovery
tdonohue
approved these changes
Apr 22, 2024
Member
tdonohue
left a comment
tdonohue
left a comment
There was a problem hiding this comment.
👍 Thanks @alexandrevryghem ! I reviewed the code and tested on the dspace-7_x branch using demo.dspace.org as the backend. This fixes the pagination issues and I've verified that it doesn't have negative effects on other paginated pages (I tested item/collection mapping, eperson/groups, and many other areas)
alexandrevryghem
deleted the
fix-broken-item-mapper-pagination_contribute-7_x
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Port of #2642 to
dspace-7_x