Skip to content

After English, reorder languages alphabetically by language code#3007

Merged
tdonohue merged 1 commit intoDSpace:mainfrom
tdonohue:reorder_langs
May 14, 2024
Merged

After English, reorder languages alphabetically by language code#3007
tdonohue merged 1 commit intoDSpace:mainfrom
tdonohue:reorder_langs

Conversation

@tdonohue
Copy link
Copy Markdown
Member

@tdonohue tdonohue commented May 3, 2024

Description

Our list of languages has turned into a bit of a random ordering. In order to have consistency & make languages easier to locate, this PR reorders all languages after English alphabetically by their language code.

This also adds ar to the default-app-config.ts as it was missing there.

@tdonohue tdonohue added code task 1 APPROVAL pull request only requires a single approval to merge port to dspace-7_x This PR needs to be ported to `dspace-7_x` branch for next bug-fix release labels May 3, 2024
@tdonohue tdonohue added this to the 8.0 milestone May 3, 2024
@kanasznagyzoltan
Copy link
Copy Markdown
Contributor

We have tested this PR and compared the order of the languages using the main branch and using this PR branch.

The main branch:
image

The order of the languages using this PR branch:
image
Looks like the languages are indeed reordered by their language codes. Only exception is the two Portugese options. The language code of “Português” (pt-PT) alphabetically comes after the language code of “Português do Brasil” (pt-BR). I suppose this was done on purpose so the original Portugese comes before the Brazilian version, just thought I would mention it.

@tdonohue
Copy link
Copy Markdown
Member Author

Merging as this had testing/verification from @kanasznagyzoltan . Thanks @kanasznagyzoltan !

@tdonohue tdonohue merged commit 3cd69dd into DSpace:main May 14, 2024
@dspace-bot
Copy link
Copy Markdown
Contributor

Backport failed for dspace-7_x, because it was unable to cherry-pick the commit(s).

Please cherry-pick the changes locally and resolve any conflicts.

git fetch origin dspace-7_x
git worktree add -d .worktree/backport-3007-to-dspace-7_x origin/dspace-7_x
cd .worktree/backport-3007-to-dspace-7_x
git switch --create backport-3007-to-dspace-7_x
git cherry-pick -x 437cc5991eb1bddb010bf4f1e189f938356bc6e6

@tdonohue tdonohue removed the port to dspace-7_x This PR needs to be ported to `dspace-7_x` branch for next bug-fix release label May 14, 2024
@tdonohue tdonohue deleted the reorder_langs branch May 14, 2024 14:29
@tdonohue
Copy link
Copy Markdown
Member Author

Ported to 7.x in #3042

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

1 APPROVAL pull request only requires a single approval to merge code task

Projects

No open projects
Status: ✅ Done

Development

Successfully merging this pull request may close these issues.

3 participants