Skip to content

Czech DSpace 7 UI translation by NTK#3025

Merged
tdonohue merged 1 commit intoDSpace:mainfrom
techlib:main
May 14, 2024
Merged

Czech DSpace 7 UI translation by NTK#3025
tdonohue merged 1 commit intoDSpace:mainfrom
techlib:main

Conversation

@dewi-g
Copy link
Copy Markdown

@dewi-g dewi-g commented May 9, 2024

Description

Added full translation of DSpace 7.6 frontend into Czech language

Instructions for Reviewers

Please notify us of any translation you disagree with on specified email, alongside opening a new pull request.

@tdonohue tdonohue added i18n / l10n Internationalisation and localisation, related to message catalogs 1 APPROVAL pull request only requires a single approval to merge labels May 9, 2024
@tdonohue
Copy link
Copy Markdown
Member

tdonohue commented May 9, 2024

@dewi-g : This PR currently has formatting (lint) errors, which is why the build is failing. It appears the cs.json5 file has formatting that doesn't align with the rules enforced by yarn lint.

You should be able to see these errors by either running yarn lint locally, or by visiting the "Files Changed" tab on this PR and opening the file changes...the errors will appear in notification boxes.

You can either fix the formatting errors manually, or you should be able to run yarn lint --fix to globally fix any formatting errors.

Once the formatting errors are fixed, you can push the changes to this PR and we'll get it reviewed for the next release of DSpace.

@dewi-g
Copy link
Copy Markdown
Author

dewi-g commented May 9, 2024

I have fixed the formatting issues and it went through most of the tests, but it failed on 20.x accessibility test (in single case). How can I fix that please? I couldn't understand anything on the ARIA rules link it linked.

@tdonohue
Copy link
Copy Markdown
Member

tdonohue commented May 9, 2024

@dewi-g : I'll restart the test. It's likely a random failure if it only fails in either 18.x or 20.x. We have a few tests which are randomly failing for some PRs & haven't yet figured out why. It's likely it will succeed for 20.x once the next run completes.

@github-actions
Copy link
Copy Markdown

Hi @dewi-g,
Conflicts have been detected against the base branch.
Please resolve these conflicts as soon as you can. Thanks!

@alexandrevryghem
Copy link
Copy Markdown
Member

@dewi-g: Your cs.json5 file currently doesn't contain the comments above the translations, these are used to track when translations might be outdated & this also prevents those values from being overridden the next time someone runs the yarn run sync-i18n script (an example of a key that will be reset the next time the script is run is: admin.registries.bitstream-formats.edit.head). This is the branch with the fixed json file, could you follow these steps in order to update this PR:

git remote add origin https://github.com/techlib/dspace-angular.git
git remote add alexandrevryghem https://github.com/alexandrevryghem/dspace-angular.git
git fetch alexandrevryghem fix-cs-json5
git push -fu origin alexandrevryghem/fix-cs-json5:main

In addition to restoring the comments, I also mapped some translations for keys that were renamed to the new keys, removed keys that were no longer used & did a sync with the latest en.json5 file

@dewi-g
Copy link
Copy Markdown
Author

dewi-g commented May 14, 2024

@tdonohue one of the tests has failed again, can you please restart it?

@tdonohue tdonohue added the port to dspace-7_x This PR needs to be ported to `dspace-7_x` branch for next bug-fix release label May 14, 2024
@tdonohue tdonohue self-requested a review May 14, 2024 16:13
Copy link
Copy Markdown
Member

@tdonohue tdonohue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Thank you @dewi-g ! I tested this today and verified that the new translations load correctly. I also verified via Google Translate that they look accurate.

@tdonohue tdonohue added this to the 8.0 milestone May 14, 2024
@tdonohue tdonohue merged commit 70cbe16 into DSpace:main May 14, 2024
@dspace-bot
Copy link
Copy Markdown
Contributor

Backport failed for dspace-7_x, because it was unable to cherry-pick the commit(s).

Please cherry-pick the changes locally and resolve any conflicts.

git fetch origin dspace-7_x
git worktree add -d .worktree/backport-3025-to-dspace-7_x origin/dspace-7_x
cd .worktree/backport-3025-to-dspace-7_x
git switch --create backport-3025-to-dspace-7_x
git cherry-pick -x ca7a9cf12007355317006c7c55a2fbbd31db1d6b

@tdonohue tdonohue removed the port to dspace-7_x This PR needs to be ported to `dspace-7_x` branch for next bug-fix release label May 14, 2024
@tdonohue
Copy link
Copy Markdown
Member

Port to 7.x in #3043

4science-it pushed a commit to 4Science/dspace-angular that referenced this pull request Apr 2, 2025
[DSC-2283] avoid metadata rendering overflowing

Approved-by: Francesco Molinaro
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

1 APPROVAL pull request only requires a single approval to merge i18n / l10n Internationalisation and localisation, related to message catalogs

Projects

No open projects
Status: ✅ Done

Development

Successfully merging this pull request may close these issues.

4 participants