Allow submitter users to accept/ignore suggestions#3030
Merged
tdonohue merged 1 commit intoDSpace:mainfrom May 10, 2024
Merged
Conversation
tdonohue
approved these changes
May 10, 2024
Member
tdonohue
left a comment
There was a problem hiding this comment.
👍 Thanks @alisaismailati ! I was able to verify the original bug. This PR fixes the problem for me as well.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
References
Description
There were initially two different button groups: for admin users and the other for non-admin users (which was allowing non-admin users only to undo an action).
Now, when the topic is marked as
WITHDRAWNorREINSTATED, we display only the button group containing a delete button for submitter users. Conversely, for other topics, submitter users will see all three buttons. Although the button group remains the same for admin and non-admin users, the delete button's functionality varies. For non-admin users, it acts as 'UNDO' action (as it was in the previous behavior for non admin users) and for the administrator it will be a 'REJECTED’ action.Screenshots
Checklist
yarn lintyarn check-circ-deps)package.json), I've made sure their licenses align with the DSpace BSD License based on the Licensing of Contributions documentation.