Skip to content

Allow submitter users to accept/ignore suggestions#3030

Merged
tdonohue merged 1 commit intoDSpace:mainfrom
4Science:task/main/DURACOM-258
May 10, 2024
Merged

Allow submitter users to accept/ignore suggestions#3030
tdonohue merged 1 commit intoDSpace:mainfrom
4Science:task/main/DURACOM-258

Conversation

@alisaismailati
Copy link
Copy Markdown
Contributor

References

Description

There were initially two different button groups: for admin users and the other for non-admin users (which was allowing non-admin users only to undo an action).

Now, when the topic is marked as WITHDRAWN or REINSTATED, we display only the button group containing a delete button for submitter users. Conversely, for other topics, submitter users will see all three buttons. Although the button group remains the same for admin and non-admin users, the delete button's functionality varies. For non-admin users, it acts as 'UNDO' action (as it was in the previous behavior for non admin users) and for the administrator it will be a 'REJECTED’ action.

Screenshots

image
image

Checklist

  • My PR is small in size (e.g. less than 1,000 lines of code, not including comments & specs/tests), or I have provided reasons as to why that's not possible.
  • My PR passes ESLint validation using yarn lint
  • My PR doesn't introduce circular dependencies (verified via yarn check-circ-deps)
  • My PR includes TypeDoc comments for all new (or modified) public methods and classes. It also includes TypeDoc for large or complex private methods.
  • My PR passes all specs/tests and includes new/updated specs or tests based on the Code Testing Guide.
  • If my PR includes new libraries/dependencies (in package.json), I've made sure their licenses align with the DSpace BSD License based on the Licensing of Contributions documentation.
  • If my PR includes new features or configurations, I've provided basic technical documentation in the PR itself.
  • If my PR fixes an issue ticket, I've linked them together.

@tdonohue tdonohue added bug 1 APPROVAL pull request only requires a single approval to merge integration: COAR Notify / LDN Related to Linked Data Notifications (LDN) or COAR Notify services labels May 10, 2024
@tdonohue tdonohue self-requested a review May 10, 2024 11:58
Copy link
Copy Markdown
Member

@tdonohue tdonohue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Thanks @alisaismailati ! I was able to verify the original bug. This PR fixes the problem for me as well.

@tdonohue tdonohue merged commit 739af16 into DSpace:main May 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

1 APPROVAL pull request only requires a single approval to merge bug integration: COAR Notify / LDN Related to Linked Data Notifications (LDN) or COAR Notify services

Projects

No open projects
Status: ✅ Done

Development

Successfully merging this pull request may close these issues.

COAR Notify Submitters can't accept/ignore suggestions

2 participants