Fix - Change color Contrast in cookie settings box#3039
Fix - Change color Contrast in cookie settings box#3039tdonohue merged 1 commit intoDSpace:dspace-7_xfrom
Conversation
There was a problem hiding this comment.
👍 Thanks @VictorHugoDuranS . I've verified this fixes the color contrast issues with the initial "We collection and process..." popup that users will see.
However, I did want to point out that if you click "Customize" on that popup, then you see a list of settings you can customize. That page still fails color contrast because it has a lot of faded gray text on a black background.
So, I'll merge this PR as a partial fix, but I'm leaving the ticket open until we can fully fix the color contrast issues.
See note I added to the original ticket for more details #2668 (comment)
|
Backport failed for Please cherry-pick the changes locally and resolve any conflicts. git fetch origin main
git worktree add -d .worktree/backport-3039-to-main origin/main
cd .worktree/backport-3039-to-main
git switch --create backport-3039-to-main
git cherry-pick -x 876ecb1d12e249da0d7dc714cf841558d3246979 |
|
Ported to main / 8.0 in #3120 |
References
Description
For resolve comments on PR Cookie setting menu accessibility bug fixed
Instructions for Reviewers
List of changes in this PR:
Using the util : https://webaim.org/resources/contrastchecker/, i found the color constrast for color
#333And edit the var color implemented by former by PR mentioned, getting the following
Checklist
This checklist provides a reminder of what we are going to look for when reviewing your PR. You need not complete this checklist prior to creating your PR (draft PRs are always welcome). If you are unsure about an item in the checklist, don't hesitate to ask. We're here to help!
yarn lintyarn check-circ-deps)package.json), I've made sure their licenses align with the DSpace BSD License based on the Licensing of Contributions documentation.