Skip to content

[Port main] Fix Author search result without co-author #3041

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tdonohue merged 4 commits into from
May 14, 2024
Merged

[Port main] Fix Author search result without co-author #3041

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
4a608b1
Fix: author search result without co-author
oscar-escire Apr 25, 2024
5532624
Fix trailing spaces and removed console.log
oscar-escire Apr 26, 2024
696a0de
Update: replaced logic of allMetadataValues method by allMetadataNoEx…
oscar-escire May 11, 2024
517b367
lint fixes
tdonohue May 14, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 11 additions & 2 deletions ...app/shared/object-list/search-result-list-element/search-result-list-element.component.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,13 +46,22 @@ export class SearchResultListElementComponent<T extends SearchResult<K>, K exten
}

/**
* Gets all matching metadata string values from hitHighlights or dso metadata, preferring hitHighlights.
* Gets all matching metadata string values from hitHighlights or dso metadata.
*
* @param {string|string[]} keyOrKeys The metadata key(s) in scope. Wildcards are supported; see [[Metadata]].
* @returns {string[]} the matching string values or an empty array.
*/
allMetadataValues(keyOrKeys: string | string[]): string[] {
return Metadata.allValues([this.object.hitHighlights, this.dso.metadata], keyOrKeys);
const dsoMetadata: string[] = Metadata.allValues([this.dso.metadata], keyOrKeys);
const highlights: string[] = Metadata.allValues([this.object.hitHighlights], keyOrKeys);
const removedHighlights: string[] = highlights.map(str => str.replace(/<\/?em>/g, ''));
for (let i = 0; i < removedHighlights.length; i++) {
const index = dsoMetadata.indexOf(removedHighlights[i]);
if (index !== -1) {
dsoMetadata[index] = highlights[i];
}
}
return dsoMetadata;
}

/**
Expand Down