Fixed item-edit.cy.ts regularly failing & minor UI improvements#3056
Merged
tdonohue merged 7 commits intoDSpace:mainfrom May 16, 2024
Merged
Conversation
- Fixed DSO edit menu sometimes displaying underneath header based on header z-index - Fixed accessibility issue on request a copy page
…dren for role="row" & added missing roles to edit comcol tabs
tdonohue
approved these changes
May 16, 2024
Member
tdonohue
left a comment
There was a problem hiding this comment.
👍 Thanks @alexandrevryghem ! This all looks great. I've tested all the various changes mentioned in the description and they all appear to be working as described. Also verified linked issue is fixed.
Member
|
@alexandrevryghem : I'm just now realizing that this probably should be partially ported to 7.x. The same I'm going to flag this as |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
References
Description
Fixed the
item-edit.cy.tsregularly failing because sometimes the<div role="row">in the<ds-dso-edit-metadata-value>doesn't contain children withrole="cell"when the accessibility checks are run. This PR also contains some other minor UI improvements.Instructions for Reviewers
List of changes in this PR:
item-edit.cy.tstest, to prove this I ran the test with the fix 50 times in the CICD and it doesn't fail anymore.container="body"to the HTML tag with the tooltip./info/coar-notify-supportnot working and replaced the logo with an SVG to save a few kb 😅ds-community-search-result-list-elementis not aligning like collections and communities<ds-my-dspace-qa-events-notifications>'s logo sometimes overflowing out of the notificationChecklist
yarn lintyarn check-circ-deps)package.json), I've made sure their licenses align with the DSpace BSD License based on the Licensing of Contributions documentation.