Fixed item edit relationships with same type name but different entities all being shown under same label#3098
Merged
tdonohue merged 2 commits intoDSpace:mainfrom Jun 7, 2024
Conversation
…into w2p-115434_byLabel-related-entity-type_contribute-main # Conflicts: # src/app/item-page/edit-item-page/item-relationships/edit-relationship-list/edit-relationship-list.component.ts
8 tasks
tdonohue
approved these changes
Jun 4, 2024
Member
tdonohue
left a comment
There was a problem hiding this comment.
👍 Thanks @alexandrevryghem ! I've tested this today with the backend PR. I can verify that this fixes the bug with Person entities related to Publication were shown twice on the Publication entity's Relationship tab (under both Person and OrgUnit). This is easily reproduced on sandbox.dspace.org for any Publication with a related Person.
Contributor
|
Backport failed for Please cherry-pick the changes locally and resolve any conflicts. git fetch origin dspace-7_x
git worktree add -d .worktree/backport-3098-to-dspace-7_x origin/dspace-7_x
cd .worktree/backport-3098-to-dspace-7_x
git switch --create backport-3098-to-dspace-7_x
git cherry-pick -x 38916ae5e70f43b3176941ce2943248288bd0bf5 |
Member
|
Manual port to 7.x in #3107 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
References
Description
Fixes the item edit relationships tab showing relationships under multiple labels when those relationship types have the same
leftwardType/rightwardType(but different entity types).Instructions for Reviewers
List of changes in this PR:
relatedEntityTypeto the request to retrieve the relationships of each individual relationship sectionGuidance for how to test/review this PR: See #1387
Checklist
yarn lintyarn check-circ-deps)package.json), I've made sure their licenses align with the DSpace BSD License based on the Licensing of Contributions documentation.