Skip to content

Fix Wrong prefix added to the year of a date input type in submission#3122

Closed
VictorHugoDuranS wants to merge 3 commits intoDSpace:dspace-7_xfrom
VictorHugoDuranS:dspace-7_2882
Closed

Fix Wrong prefix added to the year of a date input type in submission#3122
VictorHugoDuranS wants to merge 3 commits intoDSpace:dspace-7_xfrom
VictorHugoDuranS:dspace-7_2882

Conversation

@VictorHugoDuranS
Copy link
Copy Markdown
Contributor

@VictorHugoDuranS VictorHugoDuranS commented Jun 15, 2024

Hi @tdonohue , I'm @jtimal partner, I like to share this PR with you:

References

Description

Instructions for Reviewers

I added a function for year input to convert partial number years to full year values.

List of changes in this PR:

To review and check I attach a video with the changes added:

0614.mp4

Checklist

  • My PR is small in size (e.g. less than 1,000 lines of code, not including comments & specs/tests), or I have provided reasons as to why that's not possible.
  • My PR passes ESLint validation using yarn lint
  • My PR doesn't introduce circular dependencies (verified via yarn check-circ-deps)
  • My PR includes TypeDoc comments for all new (or modified) public methods and classes. It also includes TypeDoc for large or complex private methods.
  • My PR passes all specs/tests and includes new/updated specs or tests based on the Code Testing Guide.
  • If my PR includes new libraries/dependencies (in package.json), I've made sure their licenses align with the DSpace BSD License based on the Licensing of Contributions documentation.
  • If my PR includes new features or configurations, I've provided basic technical documentation in the PR itself.
  • If my PR fixes an issue ticket, I've linked them together.

@tdonohue tdonohue added bug 1 APPROVAL pull request only requires a single approval to merge component: submission port to main This PR needs to be ported to `main` branch for the next major release labels Jun 17, 2024
@tdonohue tdonohue changed the title Dspace 7 2882 Fix Wrong prefix added to the year of a date input type in submission Aug 8, 2024
@tdonohue tdonohue requested a review from atarix83 August 22, 2024 15:00
4science-it pushed a commit to 4Science/dspace-angular that referenced this pull request May 13, 2025
[IIIF-188] configure headers adaptions for allowed origins on IIIF viewer

Approved-by: Giuseppe Digilio
@tdonohue tdonohue moved this to 👀 Under Review in DSpace 10.0 Release May 19, 2025
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Apr 5, 2026

This pull request has been automatically marked as stale because it has not had
activity in one year. It will be closed in 14 days if no further activity occurs.

Allowing pull requests to close as stale helps us filter out old work that is no longer
relevant and helps developers focus on reviewing current work.

All pull requests closed by this bot act like normal pull requests;
they can be searched for, commented on or reopened at any point.

If these changes are still relevant then please comment and/or rebase your PR based on the
latest DSpace code. This will remove the stale status and notify us to assign a reviewer
for your PR.

@github-actions github-actions Bot added the stale This issue or PR is stale because it has not been updated in a long time. label Apr 5, 2026
@github-actions
Copy link
Copy Markdown

This pull request has been closed automatically. If these changes are still relevant
then please re-open this pull request with a comment and rebase your PR based on the latest
DSpace code. This will notify us to assign a reviewer to your PR.

@github-actions github-actions Bot closed this Apr 19, 2026
@github-project-automation github-project-automation Bot moved this from 👀 Under Review to ✅ Done in DSpace 10.0 Release Apr 19, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

1 APPROVAL pull request only requires a single approval to merge bug component: submission port to main This PR needs to be ported to `main` branch for the next major release stale This issue or PR is stale because it has not been updated in a long time.

Projects

Status: ✅ Done

Development

Successfully merging this pull request may close these issues.

2 participants