Skip to content

Docker compose syntax changes#3158

Merged
tdonohue merged 2 commits intoDSpace:mainfrom
pilasou:pilasou-docker-compose-syntax-change
Jul 3, 2024
Merged

Docker compose syntax changes#3158
tdonohue merged 2 commits intoDSpace:mainfrom
pilasou:pilasou-docker-compose-syntax-change

Conversation

@pilasou
Copy link
Copy Markdown
Contributor

@pilasou pilasou commented Jul 3, 2024

Changes in Docker syntax to be Docker V2 compliant. Change "docker-compose" command to "docker compose".

pilasou added 2 commits July 3, 2024 11:22
Change the docker-compose syntax to V2 syntax docker compose
@tdonohue tdonohue added code task 1 APPROVAL pull request only requires a single approval to merge backend: Docker related to DSpace deployment via Docker port to dspace-7_x This PR needs to be ported to `dspace-7_x` branch for next bug-fix release port to dspace-8_x This PR needs to be ported to `dspace-8_x` branch for next bug-fix release labels Jul 3, 2024
@tdonohue tdonohue added this to the 9.0 milestone Jul 3, 2024
Copy link
Copy Markdown
Member

@tdonohue tdonohue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Thanks @pilasou ! This all looks correct to me. It's just documentation changes. Merging and porting

@tdonohue tdonohue merged commit c3a26ea into DSpace:main Jul 3, 2024
@dspace-bot
Copy link
Copy Markdown
Contributor

Backport failed for dspace-7_x, because it was unable to cherry-pick the commit(s).

Please cherry-pick the changes locally and resolve any conflicts.

git fetch origin dspace-7_x
git worktree add -d .worktree/backport-3158-to-dspace-7_x origin/dspace-7_x
cd .worktree/backport-3158-to-dspace-7_x
git switch --create backport-3158-to-dspace-7_x
git cherry-pick -x 5e3d0fbdef64531d135177962a97bff04368714e da8a73ba0bd34dd96a23c48bc6c8301b377f7844

@dspace-bot
Copy link
Copy Markdown
Contributor

Successfully created backport PR for dspace-8_x:

@tdonohue tdonohue removed port to dspace-7_x This PR needs to be ported to `dspace-7_x` branch for next bug-fix release port to dspace-8_x This PR needs to be ported to `dspace-8_x` branch for next bug-fix release labels Jul 3, 2024
@tdonohue
Copy link
Copy Markdown
Member

tdonohue commented Jul 3, 2024

Because this could not be cleanly backported to 7.x, I've only backported to 8.x for now. We can manually backport to 7.x at a later date if necessary.

@pilasou pilasou deleted the pilasou-docker-compose-syntax-change branch February 5, 2025 21:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

1 APPROVAL pull request only requires a single approval to merge backend: Docker related to DSpace deployment via Docker code task

Projects

No open projects
Status: ✅ Done

Development

Successfully merging this pull request may close these issues.

3 participants