Skip to content

WorkspaceitemsEditPageModule: remove duplicated delete route#3234

Merged
tdonohue merged 1 commit intoDSpace:mainfrom
saschaszott:patch-25
Aug 7, 2024
Merged

WorkspaceitemsEditPageModule: remove duplicated delete route#3234
tdonohue merged 1 commit intoDSpace:mainfrom
saschaszott:patch-25

Conversation

@saschaszott
Copy link
Copy Markdown
Contributor

Description

This PR removes a duplicated /delete route in WorkspaceitemsEditPageModule.

@tdonohue tdonohue added code task 1 APPROVAL pull request only requires a single approval to merge port to dspace-8_x This PR needs to be ported to `dspace-8_x` branch for next bug-fix release labels Aug 7, 2024
@tdonohue tdonohue added this to the 9.0 milestone Aug 7, 2024
Copy link
Copy Markdown
Member

@tdonohue tdonohue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Thanks @saschaszott ! This is obviously correct. This exact route code appears twice in the file. Porting also to 8.x as the duplication appears there as well.

@dspace-bot
Copy link
Copy Markdown
Contributor

Successfully created backport PR for dspace-8_x:

@alexandrevryghem alexandrevryghem removed the port to dspace-8_x This PR needs to be ported to `dspace-8_x` branch for next bug-fix release label Nov 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

1 APPROVAL pull request only requires a single approval to merge code task

Projects

No open projects
Status: ✅ Done

Development

Successfully merging this pull request may close these issues.

4 participants