Skip to content

Fix lint error regarding missing interface#3243

Merged
tdonohue merged 1 commit intoDSpace:mainfrom
tdonohue:fix_lint_error
Aug 9, 2024
Merged

Fix lint error regarding missing interface#3243
tdonohue merged 1 commit intoDSpace:mainfrom
tdonohue:fix_lint_error

Conversation

@tdonohue
Copy link
Copy Markdown
Member

@tdonohue tdonohue commented Aug 8, 2024

References

Description

After merging #3048, main is now throwing this lint error:

/home/runner/work/dspace-angular/dspace-angular/src/app/notifications/suggestion-targets/publication-claim/publication-claim.component.ts
Lint errors found in the listed files.
Error:   110:3  error  Lifecycle interface 'AfterViewInit' should be implemented for method 'ngAfterViewInit'. (https://angular.io/styleguide#style-09-01)  @angular-eslint/use-lifecycle-interface

This small PR fixes that error

@tdonohue tdonohue added code task 1 APPROVAL pull request only requires a single approval to merge labels Aug 8, 2024
@tdonohue tdonohue added this to the 9.0 milestone Aug 8, 2024
@tdonohue
Copy link
Copy Markdown
Member Author

tdonohue commented Aug 9, 2024

Merging immediately as this fixes a lint error currently on main.

@tdonohue tdonohue added the port to dspace-8_x This PR needs to be ported to `dspace-8_x` branch for next bug-fix release label Aug 9, 2024
@tdonohue tdonohue merged commit ee7e835 into DSpace:main Aug 9, 2024
@dspace-bot
Copy link
Copy Markdown
Contributor

Successfully created backport PR for dspace-8_x:

@tdonohue tdonohue deleted the fix_lint_error branch August 9, 2024 13:59
@tdonohue tdonohue removed the port to dspace-8_x This PR needs to be ported to `dspace-8_x` branch for next bug-fix release label Aug 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

1 APPROVAL pull request only requires a single approval to merge code task

Projects

No open projects
Status: ✅ Done

Development

Successfully merging this pull request may close these issues.

2 participants