Minor accessibility fixes#3251
Merged
kshepherd merged 4 commits intoDSpace:mainfrom Aug 29, 2024
Merged
Conversation
…licate ID issue by removing the unused #browseDropdown ID
…ute-7.2' into w2p-110615_minor-accessibibity-fixes_contribute-7.6 # Conflicts: # src/app/navbar/expandable-navbar-section/expandable-navbar-section.component.html
…to w2p-110615_minor-accessibibity-fixes_contribute-main # Conflicts: # src/app/item-page/simple/related-entities/tabbed-related-entities-search/tabbed-related-entities-search.component.html # src/app/navbar/expandable-navbar-section/expandable-navbar-section.component.html # src/app/shared/form/vocabulary-treeview/vocabulary-treeview.component.html
alexandrevryghem
added
accessibility
affects: 8.x
tdonohue
added
port to dspace-7_x
kshepherd
approved these changes
Aug 29, 2024
Member
kshepherd
left a comment
kshepherd
left a comment
There was a problem hiding this comment.
+1 thanks @alexandrevryghem , changes look good and i have tested them locally
Contributor
|
Backport failed for Please cherry-pick the changes locally and resolve any conflicts. git fetch origin dspace-7_x
git worktree add -d .worktree/backport-3251-to-dspace-7_x origin/dspace-7_x
cd .worktree/backport-3251-to-dspace-7_x
git switch --create backport-3251-to-dspace-7_x
git cherry-pick -x a0515c412140184c23cface4febb5d48f0d430eb 54d99a84c9eb59335f9e62b3b043f86ccd1f80d3 |
Contributor
|
Backport failed for Please cherry-pick the changes locally and resolve any conflicts. git fetch origin dspace-8_x
git worktree add -d .worktree/backport-3251-to-dspace-8_x origin/dspace-8_x
cd .worktree/backport-3251-to-dspace-8_x
git switch --create backport-3251-to-dspace-8_x
git cherry-pick -x a0515c412140184c23cface4febb5d48f0d430eb 54d99a84c9eb59335f9e62b3b043f86ccd1f80d3 |
Member
|
@alexandrevryghem our auto-backports didn't work due to conflicts, would it be much trouble for you to push some hand-made PRs for the 7_x and 8_x branches? |
Member
Author
|
@kshepherd: No this won't take much time, I created the code on the dspace-7.6 tag, so this should be fairly simple |
alexandrevryghem
deleted the
w2p-110615_minor-accessibibity-fixes_contribute-main
branch
This was referenced Sep 24, 2024
alexandrevryghem
removed
port to dspace-7_x
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
These are minor fixes that were required in order to fix some issues regarding accessibility on the item page & the browse controlled vocabulary page.
Instructions for Reviewers
In order to detect these issues we used Silktide
List of changes in this PR:
browseDropdownfromExpandableNavbarSectionComponent, since it's not used anywhere an that component is also not meant to be browse specific. This caused a duplicate id issue when you used 2 expandable secitons in your navbarChecklist
mainbranch of code (unless it is a backport or is fixing an issue specific to an older branch).yarn lintyarn check-circ-deps)package.json), I've made sure their licenses align with the DSpace BSD License based on the Licensing of Contributions documentation.