[Port dspace-7_x] support for disabled buttons for screen readers#3270
Merged
tdonohue merged 11 commits intoDSpace:dspace-7_xfrom Jan 28, 2025
Conversation
added 6 commits
August 23, 2024 14:10
…ders-7.6' into w2p-117544_support-for-disabled-elements-for-screen-readers-7.x
12 tasks
tdonohue
changed the title
added 3 commits
September 16, 2024 14:24
- added typedocs - changed directive to only be present for buttons - various other small fixes
|
Hi @jensvannerum, |
…ort-for-disabled-elements-for-screen-readers-7.x
tdonohue
requested changes
Jan 24, 2025
Member
tdonohue
left a comment
tdonohue
left a comment
There was a problem hiding this comment.
@jensvannerum : This looks mostly good! However, I found a minor mistake in this backport.
It appears you've accidently created an empty src/app/admin/admin-reports/filtered-items/filtered-items.component.html file in this PR. That feature only exists in 8.x and above, so this file should be removed.
jensvannerum
force-pushed
the
w2p-117544_support-for-disabled-elements-for-screen-readers-7.x
branch
from
6e88bee to
cd2f8ab
Compare
tdonohue
changed the title
tdonohue
approved these changes
Jan 28, 2025
Member
tdonohue
left a comment
tdonohue
left a comment
There was a problem hiding this comment.
👍 Thanks @jensvannerum ! I gave this a quick test on 7.x to make sure it works the same, and it does. Code looks good now too.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
References
This is a backport to DSpace 7 of #3268
Description
see #3268
Checklist
mainbranch of code (unless it is a backport or is fixing an issue specific to an older branch).yarn lintyarn check-circ-deps)package.json), I've made sure their licenses align with the DSpace BSD License based on the Licensing of Contributions documentation.