Skip to content

Provided label for cclicense required error#3287

Merged
tdonohue merged 1 commit intoDSpace:mainfrom
4Science:task/main/DURACOM-265
Sep 3, 2024
Merged

Provided label for cclicense required error#3287
tdonohue merged 1 commit intoDSpace:mainfrom
4Science:task/main/DURACOM-265

Conversation

@Sondissimo
Copy link
Copy Markdown
Contributor

References

Supplements: DSpace/DSpace#9639 (review)

Description

Provided error label for DSpace/DSpace#9639

List of changes in this PR:
Provided error label

  • [x ] My PR is created against the main branch of code (unless it is a backport or is fixing an issue specific to an older branch).
  • x[ ] My PR is small in size (e.g. less than 1,000 lines of code, not including comments & specs/tests), or I have provided reasons as to why that's not possible.
  • [ x] My PR passes ESLint validation using yarn lint
  • [x ] My PR doesn't introduce circular dependencies (verified via yarn check-circ-deps)
  • [ x] My PR passes all specs/tests and includes new/updated specs or tests based on the Code Testing Guide.
  • [ x] My PR aligns with Accessibility guidelines if it makes changes to the user interface.
  • [x ] My PR uses i18n (internationalization) keys instead of hardcoded English text, to allow for translations.
  • [ x] My PR includes details on how to test it. I've provided clear instructions to reviewers on how to successfully test this fix or feature.
  • [x ] If my PR includes new features or configurations, I've provided basic technical documentation in the PR itself.
  • [x ] If my PR fixes an issue ticket, I've linked them together.

Copy link
Copy Markdown
Member

@tdonohue tdonohue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Thanks @Sondissimo !

@tdonohue tdonohue changed the title DURACOM-265 provided label for cclicense required error Provided label for cclicense required error Sep 3, 2024
@tdonohue tdonohue merged commit 027a4e5 into DSpace:main Sep 3, 2024
@tdonohue tdonohue added this to the 9.0 milestone Feb 7, 2025
atarix83 added a commit to 4Science/dspace-angular that referenced this pull request Nov 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

1 APPROVAL pull request only requires a single approval to merge improvement integration: Creative Commons Related to CC license

Projects

No open projects
Status: ✅ Done

Development

Successfully merging this pull request may close these issues.

2 participants