#3288 - Enabled 'admin-div' only for Site Administrator

[Simone-Ramundi]

References

• Fixes Community admins wrongly see the button to create top-level communities #3288

Description

This PR introduces a change to the CreateCommunityParentSelectorComponent to display the admin-div section only to users with Site Administrator privileges.

Instructions for Reviewers

The key changes include:

• New isAdmin$ Observable: Added an isAdmin$ observable to the CreateCommunityParentSelectorComponent to track admin status.

• Conditional Rendering: Added a <div> with data-test="admin-div" in the component's template, which is displayed only if isAdmin$ emits true.

• Updated Tests: Adjusted the unit tests to check for the presence of the admin-div based on the admin status.

How to test:

1. Log in as Community admin on https://demo.dspace.org/home
2. On the admin bar, click on New -> Community
3. Verify that the admin-div is not visible.

This will confirm that the admin-div is correctly shown or hidden based on the user's admin status.

Checklist

• My PR is created against the main branch of code (unless it is a backport or is fixing an issue specific to an older branch).
• My PR is small in size (e.g. less than 1,000 lines of code, not including comments & specs/tests), or I have provided reasons as to why that's not possible.
• My PR passes ESLint validation using yarn lint
• My PR doesn't introduce circular dependencies (verified via yarn check-circ-deps)
• My PR includes TypeDoc comments for all new (or modified) public methods and classes. It also includes TypeDoc for large or complex private methods.
• My PR passes all specs/tests and includes new/updated specs or tests based on the Code Testing Guide.
• My PR aligns with Accessibility guidelines if it makes changes to the user interface.
• My PR uses i18n (internationalization) keys instead of hardcoded English text, to allow for translations.
• My PR includes details on how to test it. I've provided clear instructions to reviewers on how to successfully test this fix or feature.
• If my PR includes new libraries/dependencies (in package.json), I've made sure their licenses align with the DSpace BSD License based on the Licensing of Contributions documentation.
• If my PR includes new features or configurations, I've provided basic technical documentation in the PR itself.
• If my PR fixes an issue ticket, I've linked them together.

[nwoodward]

Thanks @Simone-Ramundi! I tested these changes, and they work well.

[alanorth]

Thanks @Simone-Ramundi. I also tested this and found it works as expected. Since this is 1 APPROVAL pull request only requires a single approval to merge and it passes all tests in CI I think we can merge this now.

[dspace-bot]

Backport failed for dspace-7_x, because it was unable to cherry-pick the commit(s).

Please cherry-pick the changes locally and resolve any conflicts.

git fetch origin dspace-7_x
git worktree add -d .worktree/backport-3308-to-dspace-7_x origin/dspace-7_x
cd .worktree/backport-3308-to-dspace-7_x
git switch --create backport-3308-to-dspace-7_x
git cherry-pick -x 4d5910981ab239f36b174a2724aeb5ba6a846fa6

[dspace-bot]

Successfully created backport PR for dspace-8_x:

• [Port dspace-8_x] #3288 - Enabled 'admin-div' only for Site Administrator #3695

[alanorth]

Dear @Simone-Ramundi, the automatic backport to dspace-7_x failed. If you have time would you be able to create a manual port? Thank you!

[Simone-Ramundi]

Thank you for bringing this up, @alanorth. There you go: #3696. Let me know if there’s anything else to address.