Fix navbar wrapping on medium screens#3513
Merged
tdonohue merged 3 commits intoDSpace:mainfrom May 9, 2025
Merged
Conversation
|
Hi @AndreaBarbasso, |
# Conflicts: # src/themes/dspace/app/header/header.component.html # src/themes/dspace/app/navbar/navbar.component.html
|
Hi @AndreaBarbasso, |
# Conflicts: # src/themes/dspace/app/header/header.component.html
Contributor
|
Successfully created backport PR for |
Contributor
|
We have checked out the PR branch, when modifying the size with the devtools window, it works correctly. DSpace.Repository.__.DSpace.-.Kozosseg.lista.-.Google.Chrome.2025-05-07.14-49-37_converted.mp4But when I change to laptop view in the dev tools, and start changing the screen the navbar still wraps, I don’t know if this is a problem, but apart from this it works. DSpace.Repository.__.DSpace.-.Kozosseg.lista.-.Google.Chrome.2025-05-07.14-04-54_converted.mp4 |
atarix83
pushed a commit
to 4Science/dspace-angular
that referenced
this pull request
Feb 20, 2026
Task/test/uon repository/CST-22088 Approved-by: Daniele Ninfo
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
References
Description
Removed a
white-space: nowraprule, added someflex-shrinkandflex-growclasses, and removed aflex-wrapclass so that the navbar is not wrapping anymore on two lines.Instructions for Reviewers
As said on #3512, on medium-sized screens the navbar could wrap on another row if there were more than 3 items in it. This PR introduces some template and style changes to avoid this behavior.
List of changes in this PR:
white-space: nowrap;rule` that was wrapping the navbar onto another row;To reproduce the issue you can simply duplicate a navbar item and resize the screen. With this PR there is no wrapping or overflowing of items.
Checklist
mainbranch of code (unless it is a backport or is fixing an issue specific to an older branch).npm run lintnpm run check-circ-deps)package.json), I've made sure their licenses align with the DSpace BSD License based on the Licensing of Contributions documentation.