Skip to content

Aligning the browse button #3524

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
kshepherd merged 1 commit into from
Oct 24, 2024
Merged

Aligning the browse button #3524

kshepherd merged 1 commit into from
Oct 24, 2024

Conversation

@Andrea-Guevara
Copy link
Contributor

@Andrea-Guevara Andrea-Guevara commented Oct 22, 2024

References

Description

Aligning the browse button to upload a file.

Instructions for Reviewers

List of changes in this PR:

  • In the “UploaderComponent” component, the “d-flex align-items-center” bootstrap classes were added to the span containing the text and the button to search for a file and upload it.
  • To give spacing between the upload icon and the explanatory text, the “pr-1” class has been added.

Include guidance for how to test or review your PR.
To Reproduce:

  1. Login.
  2. Go to MyDSpace.
  3. Note that the upload box at the top of the page now has all its elements aligned.

Checklist

  • My PR is created against the main branch of code (unless it is a backport or is fixing an issue specific to an older branch).
  • My PR is small in size (e.g. less than 1,000 lines of code, not including comments & specs/tests), or I have provided reasons as to why that's not possible.
  • My PR passes ESLint validation using npm run lint
  • My PR doesn't introduce circular dependencies (verified via npm run check-circ-deps)
  • My PR includes TypeDoc comments for all new (or modified) public methods and classes. It also includes TypeDoc for large or complex private methods.
  • My PR passes all specs/tests and includes new/updated specs or tests based on the Code Testing Guide.
  • My PR aligns with Accessibility guidelines if it makes changes to the user interface.
  • My PR uses i18n (internationalization) keys instead of hardcoded English text, to allow for translations.
  • My PR includes details on how to test it. I've provided clear instructions to reviewers on how to successfully test this fix or feature.
  • If my PR includes new libraries/dependencies (in package.json), I've made sure their licenses align with the DSpace BSD License based on the Licensing of Contributions documentation.
  • If my PR includes new features or configurations, I've provided basic technical documentation in the PR itself.
  • If my PR fixes an issue ticket, I've linked them together.

@tdonohue tdonohue added bug 1 APPROVAL pull request only requires a single approval to merge port to dspace-7_x This PR needs to be ported to `dspace-7_x` branch for next bug-fix release port to dspace-8_x This PR needs to be ported to `dspace-8_x` branch for next bug-fix release labels Oct 22, 2024
kshepherd
kshepherd approved these changes Oct 24, 2024
View reviewed changes
Copy link
Member

@kshepherd kshepherd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 tested, works perfectly and the template change looks great, thanks @Andrea-Guevara !

@kshepherd kshepherd merged commit 9c4e8a3 into DSpace:main Oct 24, 2024
@dspace-bot
Copy link
Contributor

dspace-bot commented Oct 24, 2024

Successfully created backport PR for dspace-7_x:

@dspace-bot dspace-bot mentioned this pull request Oct 24, 2024
Merged
@dspace-bot
Copy link
Contributor

dspace-bot commented Oct 24, 2024

Successfully created backport PR for dspace-8_x:

@dspace-bot dspace-bot mentioned this pull request Oct 24, 2024
Merged
@tdonohue tdonohue added this to the 9.0 milestone Oct 24, 2024
@tdonohue tdonohue removed port to dspace-7_x This PR needs to be ported to `dspace-7_x` branch for next bug-fix release port to dspace-8_x This PR needs to be ported to `dspace-8_x` branch for next bug-fix release labels Oct 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kshepherd kshepherd kshepherd approved these changes

Assignees

@Andrea-Guevara Andrea-Guevara

Labels

1 APPROVAL pull request only requires a single approval to merge bug

Projects

No open projects
DSpace 9.0 Release
Status: ✅ Done

Milestone

9.0

Development

Successfully merging this pull request may close these issues.

The word "browse" is misaligned in the uploader component

4 participants

@Andrea-Guevara @dspace-bot @kshepherd @tdonohue