Remove unused PostCSS plugins #3547
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tdonohue
added
dependencies
Member
Author
|
This should be backported to 8.x and 7.x, as these PostCSS plugins are unused in those versions as well. I'll create manual backports. |
tdonohue
added
port to dspace-7_x
This was referenced Oct 23, 2024
alanorth
removed
the
port to dspace-7_x
kshepherd
approved these changes
Oct 24, 2024
Member
kshepherd
left a comment
kshepherd
left a comment
There was a problem hiding this comment.
+1 tests well (and the 7.x backport is already reviewed and merged)
Contributor
|
Backport failed for Please cherry-pick the changes locally and resolve any conflicts. git fetch origin dspace-8_x
git worktree add -d .worktree/backport-3547-to-dspace-8_x origin/dspace-8_x
cd .worktree/backport-3547-to-dspace-8_x
git switch --create backport-3547-to-dspace-8_x
git cherry-pick -x c93ed03004ddff1186548342b853df2281bdb43a 39c5c755d75339230681d45fec5b4878634d7e16 |
Member
|
@tdonohue the failed backport could be because of the previous merges that also change package.json so hopefully not hard to manually create |
Member
Author
|
@kshepherd : the automated backport error is expected. I should have removed that This PR was already (manually) ported to both 8.x and 7.x: |
tdonohue
removed
the
port to dspace-8_x
atarix83
pushed a commit
to 4Science/dspace-angular
that referenced
this pull request
Nov 3, 2025
[GLAM-952] fix issue with bitstream observable emission Approved-by: Vincenzo Mecca
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Several PostCSS plugins are installed in DSpace but are unused. Specifically:
postcss-apply(used via@apply...which is never used in our SCSS files)postcss-responsive-type(used viaresponsive...which is never used in our SCSS files)Because these are unused, I'm removing them completely. Both of these plugins also rely on outdated versions of PostCSS. So, removing them makes it much easier to upgrade PostCSS in the future.
Instructions for Reviewers