Skip to content

Fixes typo for 'descrption'#3737

Merged
alanorth merged 1 commit intoDSpace:mainfrom
TexasDigitalLibrary:fix-typo-browse-metadata
Jan 3, 2025
Merged

Fixes typo for 'descrption'#3737
alanorth merged 1 commit intoDSpace:mainfrom
TexasDigitalLibrary:fix-typo-browse-metadata

Conversation

@nwoodward
Copy link
Copy Markdown
Contributor

Description

Fixes misspellings in metadata browsing translations.

Checklist

  • My PR is created against the main branch of code (unless it is a backport or is fixing an issue specific to an older branch).
  • My PR is small in size (e.g. less than 1,000 lines of code, not including comments & specs/tests), or I have provided reasons as to why that's not possible.
  • My PR passes ESLint validation using npm run lint
  • My PR doesn't introduce circular dependencies (verified via npm run check-circ-deps)
  • My PR includes TypeDoc comments for all new (or modified) public methods and classes. It also includes TypeDoc for large or complex private methods.
  • My PR passes all specs/tests and includes new/updated specs or tests based on the Code Testing Guide.
  • My PR aligns with Accessibility guidelines if it makes changes to the user interface.
  • My PR uses i18n (internationalization) keys instead of hardcoded English text, to allow for translations.
  • My PR includes details on how to test it. I've provided clear instructions to reviewers on how to successfully test this fix or feature.
  • If my PR includes new libraries/dependencies (in package.json), I've made sure their licenses align with the DSpace BSD License based on the Licensing of Contributions documentation.
  • If my PR includes new features or configurations, I've provided basic technical documentation in the PR itself.
  • If my PR fixes an issue ticket, I've linked them together.

@tdonohue tdonohue added i18n / l10n Internationalisation and localisation, related to message catalogs 1 APPROVAL pull request only requires a single approval to merge labels Dec 9, 2024
@nwoodward nwoodward added the port to dspace-8_x This PR needs to be ported to `dspace-8_x` branch for next bug-fix release label Jan 2, 2025
@alanorth alanorth added this to the 9.0 milestone Jan 3, 2025
@alanorth
Copy link
Copy Markdown
Contributor

alanorth commented Jan 3, 2025

Thanks @nwoodward. This is obviously correct. The code in src/app/browse-by/browse-by-taxonomy/browse-by-taxonomy.component.ts calls description:

this.description = this.translate.instant(`browse.metadata.${this.vocabularyName}.tree.description`);

Merging ASAP as this is 1 APPROVAL pull request only requires a single approval to merge .

@alanorth alanorth merged commit 08f48d8 into DSpace:main Jan 3, 2025
@dspace-bot
Copy link
Copy Markdown
Contributor

Successfully created backport PR for dspace-8_x:

@alanorth alanorth removed the port to dspace-8_x This PR needs to be ported to `dspace-8_x` branch for next bug-fix release label Jan 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

1 APPROVAL pull request only requires a single approval to merge i18n / l10n Internationalisation and localisation, related to message catalogs

Projects

No open projects
Status: ✅ Done

Development

Successfully merging this pull request may close these issues.

4 participants