Skip to content

Conversation

@alexandrevryghem
Copy link
Member

Port of #3724 to dspace-8_x.

@alexandrevryghem alexandrevryghem added bug component: submission component: controlled vocabulary related to controlled vocabulary or value-pairs dropdowns 1 APPROVAL pull request only requires a single approval to merge labels Jan 3, 2025
@alexandrevryghem alexandrevryghem added this to the 8.1 milestone Jan 3, 2025
@alexandrevryghem alexandrevryghem self-assigned this Jan 3, 2025
@tdonohue
Copy link
Member

tdonohue commented Jan 6, 2025

@alexandrevryghem : this appears to be missing part of the fix in #3724. I see this PR only fixes the dynamic-scrollable-dropdown.component.html, but does NOT fix the dynamic-lookup-component.html. Was that on purpose?

The 7.x port (in #3795) is the same. It doesn't appear to include all the fixes applied to main.

@tdonohue tdonohue self-requested a review January 6, 2025 15:06
…ting the enter key in another input field

(cherry picked from commit c8694e1)
@alexandrevryghem
Copy link
Member Author

@tdonohue: No that wasn't on purpose, my bad 😅. I added the missing commit to both PRs.

@tdonohue
Copy link
Member

tdonohue commented Jan 6, 2025

@alexandrevryghem : no worries! Glad I caught it then. I'll make sure they both pass tests & then merge them immediately (since the main version is already merged)

@tdonohue tdonohue merged commit 6fe351a into DSpace:dspace-8_x Jan 6, 2025
15 checks passed
@alexandrevryghem alexandrevryghem deleted the w2p-122005_fixed-dropdown-values-resetting-on-enter_contribute-8_x branch January 6, 2025 22:31
4science-it pushed a commit to 4Science/dspace-angular that referenced this pull request Nov 13, 2025
[DSC-2580] improve header.cy language switch test

Approved-by: Francesco Molinaro
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

1 APPROVAL pull request only requires a single approval to merge bug component: controlled vocabulary related to controlled vocabulary or value-pairs dropdowns component: submission

Projects

Development

Successfully merging this pull request may close these issues.

2 participants