Attempt to stabilize a few randomly failing e2e tests#3842
Merged
tdonohue merged 2 commits intoDSpace:mainfrom Jan 15, 2025
Merged
Attempt to stabilize a few randomly failing e2e tests#3842tdonohue merged 2 commits intoDSpace:mainfrom
tdonohue merged 2 commits intoDSpace:mainfrom
Conversation
Member
Author
|
Merging immediately & porting. Hoping this stabilizes things a bit more (several of these are randomly failing at a greater frequency recently) |
Contributor
|
Backport failed for Please cherry-pick the changes locally and resolve any conflicts. git fetch origin dspace-7_x
git worktree add -d .worktree/backport-3842-to-dspace-7_x origin/dspace-7_x
cd .worktree/backport-3842-to-dspace-7_x
git switch --create backport-3842-to-dspace-7_x
git cherry-pick -x 5623cc9221ef55f073d54b30efcf42684e9a4455 7feb9fc617f88f57927eb7d6de7b4ed8fa0ce870 |
Contributor
|
Backport failed for Please cherry-pick the changes locally and resolve any conflicts. git fetch origin dspace-8_x
git worktree add -d .worktree/backport-3842-to-dspace-8_x origin/dspace-8_x
cd .worktree/backport-3842-to-dspace-8_x
git switch --create backport-3842-to-dspace-8_x
git cherry-pick -x 5623cc9221ef55f073d54b30efcf42684e9a4455 7feb9fc617f88f57927eb7d6de7b4ed8fa0ce870 |
This was referenced Jan 15, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This small PR is an attempt to stabilize a few randomly failing e2e tests.
item-edit.cy.tswill sometimes randomly fail if the tabs have not fully loaded. The second commit attempts to fix this issue by waiting on the current tab to be visible before clicking on it, and then ensuring it's visible again after reload of the page.Instructions for Reviewers