Skip to content

Update fr.json5 - 'Parcourir DSpace' and 'Rechercher un(e) collection' #3866

Closed
alphapetjg wants to merge 1 commit intoDSpace:mainfrom
alphapetjg:patch-2
Closed

Update fr.json5 - 'Parcourir DSpace' and 'Rechercher un(e) collection' #3866
alphapetjg wants to merge 1 commit intoDSpace:mainfrom
alphapetjg:patch-2

Conversation

@alphapetjg
Copy link
Copy Markdown
Contributor

Description

Corrected translations: 'Tout DSpace' to 'Parcourir DSpace' (more accurate with the intended meaning) and adjusted translation for 'Rechercher une collection' to 'Rechercher un(e) collection' (ensures grammatical correctness).

Instructions for Reviewers

Deploy PR and observe changes are present in UI (Browse menu, Search menu).

Checklist

  • My PR is created against the main branch of code (unless it is a backport or is fixing an issue specific to an older branch).
  • My PR is small in size (e.g. less than 1,000 lines of code, not including comments & specs/tests), or I have provided reasons as to why that's not possible.
  • My PR passes ESLint validation using npm run lint
  • My PR doesn't introduce circular dependencies (verified via npm run check-circ-deps)
  • My PR includes TypeDoc comments for all new (or modified) public methods and classes. It also includes TypeDoc for large or complex private methods.
  • My PR passes all specs/tests and includes new/updated specs or tests based on the Code Testing Guide.
  • My PR aligns with Accessibility guidelines if it makes changes to the user interface.
  • [X]My PR uses i18n (internationalization) keys instead of hardcoded English text, to allow for translations.
  • My PR includes details on how to test it. I've provided clear instructions to reviewers on how to successfully test this fix or feature.
  • If my PR includes new libraries/dependencies (in package.json), I've made sure their licenses align with the DSpace BSD License based on the Licensing of Contributions documentation.
  • If my PR includes new features or configurations, I've provided basic technical documentation in the PR itself.
  • If my PR fixes an issue ticket, I've linked them together.

Corrected translations: 'Tout DSpace' to 'Parcourir DSpace' (more accurate) and 'Rechercher une collection' to 'Rechercher un(e) collection'.
@tdonohue tdonohue added i18n / l10n Internationalisation and localisation, related to message catalogs 1 APPROVAL pull request only requires a single approval to merge labels Jan 21, 2025
Copy link
Copy Markdown
Contributor

@pilasou pilasou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it is better to leave the submission.sections.general.search-collection as-is. Collection in french is always feminine. The other change is correct. Thanks!

Comment thread src/assets/i18n/fr.json5

// "submission.sections.general.search-collection": "Search for a collection",
"submission.sections.general.search-collection": "Rechercher une collection",
"submission.sections.general.search-collection": "Rechercher un(e) collection",
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As this label applies only to Collection, it is better to simply use "une" as "collection" in french is always feminine.

@tdonohue tdonohue moved this to 👀 Under Review in DSpace 10.0 Release May 19, 2025
4science-it pushed a commit to 4Science/dspace-angular that referenced this pull request Dec 3, 2025
chore(i18n): Add addressLocality (City) translation key for organization address

Approved-by: Fapohunda, Adamo
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Feb 8, 2026

This pull request has been automatically marked as stale because it has not had
activity in one year. It will be closed in 14 days if no further activity occurs.

Allowing pull requests to close as stale helps us filter out old work that is no longer
relevant and helps developers focus on reviewing current work.

All pull requests closed by this bot act like normal pull requests;
they can be searched for, commented on or reopened at any point.

If these changes are still relevant then please comment and/or rebase your PR based on the
latest DSpace code. This will remove the stale status and notify us to assign a reviewer
for your PR.

@github-actions github-actions Bot added the stale This issue or PR is stale because it has not been updated in a long time. label Feb 8, 2026
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Mar 1, 2026

This pull request has been closed automatically. If these changes are still relevant
then please re-open this pull request with a comment and rebase your PR based on the latest
DSpace code. This will notify us to assign a reviewer to your PR.

@github-actions github-actions Bot closed this Mar 1, 2026
@github-project-automation github-project-automation Bot moved this from 👀 Under Review to ✅ Done in DSpace 10.0 Release Mar 1, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

1 APPROVAL pull request only requires a single approval to merge i18n / l10n Internationalisation and localisation, related to message catalogs stale This issue or PR is stale because it has not been updated in a long time.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants