Update fr.json5 - 'Parcourir DSpace' and 'Rechercher un(e) collection' #3866
Update fr.json5 - 'Parcourir DSpace' and 'Rechercher un(e) collection' #3866alphapetjg wants to merge 1 commit intoDSpace:mainfrom
Conversation
Corrected translations: 'Tout DSpace' to 'Parcourir DSpace' (more accurate) and 'Rechercher une collection' to 'Rechercher un(e) collection'.
pilasou
left a comment
There was a problem hiding this comment.
I think it is better to leave the submission.sections.general.search-collection as-is. Collection in french is always feminine. The other change is correct. Thanks!
|
|
||
| // "submission.sections.general.search-collection": "Search for a collection", | ||
| "submission.sections.general.search-collection": "Rechercher une collection", | ||
| "submission.sections.general.search-collection": "Rechercher un(e) collection", |
There was a problem hiding this comment.
As this label applies only to Collection, it is better to simply use "une" as "collection" in french is always feminine.
chore(i18n): Add addressLocality (City) translation key for organization address Approved-by: Fapohunda, Adamo
|
This pull request has been automatically marked as stale because it has not had Allowing pull requests to close as stale helps us filter out old work that is no longer All pull requests closed by this bot act like normal pull requests; If these changes are still relevant then please comment and/or rebase your PR based on the |
|
This pull request has been closed automatically. If these changes are still relevant |
Description
Corrected translations: 'Tout DSpace' to 'Parcourir DSpace' (more accurate with the intended meaning) and adjusted translation for 'Rechercher une collection' to 'Rechercher un(e) collection' (ensures grammatical correctness).
Instructions for Reviewers
Deploy PR and observe changes are present in UI (Browse menu, Search menu).
Checklist
mainbranch of code (unless it is a backport or is fixing an issue specific to an older branch).npm run lintnpm run check-circ-deps)package.json), I've made sure their licenses align with the DSpace BSD License based on the Licensing of Contributions documentation.