Skip to content

Fix for DSpace#2328 Highlighting the sidebar filter facets if any val…#4078

Closed
Bhoma38 wants to merge 2 commits intoDSpace:mainfrom
Bhoma38:feature-branch
Closed

Fix for DSpace#2328 Highlighting the sidebar filter facets if any val…#4078
Bhoma38 wants to merge 2 commits intoDSpace:mainfrom
Bhoma38:feature-branch

Conversation

@Bhoma38
Copy link

@Bhoma38 Bhoma38 commented Mar 13, 2025

Description

Fixes #2328

Collapsed sidebar filter facets should indicate if a value is selected

Instructions for Reviewers

When users apply multiple filters on the /search page, they often collapse individual facets. This makes it difficult to track which filters are active without expanding each section.

Expected Behavior

Sidebar filter facets should clearly indicate if they're "active", especially when they're collapsed.

List of Changes in this PR:

  • Added a variable $highlightColor: rgba(30, 111, 144, 0.3) !default in src/styles/_bootstrap_variables.scss
  • Mapped --bs-highlight-color: #{$highlightColor} in src/styles/_bootstrap_variables_mapping.scss
  • Added background color (--bs-highlight-color) when checkbox is checked in ds-search-filter in src/styles/_global-styles.scss

Steps to Test and Reproduce the Behavior:

On the /search page, when you select a checkbox within a filter, the filter becomes active. If you collapse the filter, it remains active as long as a checkbox is selected. If no checkbox is selected, the filter is not activated.

@tdonohue tdonohue added component: Discovery related to discovery search or browse system 1 APPROVAL pull request only requires a single approval to merge improvement labels Mar 13, 2025
@tdonohue tdonohue moved this to 🙋 Needs Reviewers Assigned in DSpace 9.0 Release Mar 13, 2025
@kanasznagyzoltan
Copy link
Contributor

It doesn’t seem to be working for me, might require further testing

DSpace.Repository.-.Sidebar_converted.mp4

@tdonohue tdonohue moved this to 🙋 Needs Reviewers Assigned in DSpace 10.0 Release May 19, 2025
@PitbaranK
Copy link

@tdonohue,
Kindly help us by reviewing and merging the changes in this pull request.
If you have any feedback or suggestions, please feel free to share. we’re happy to connect and make any necessary adjustments.

@tdonohue
Copy link
Member

@PitbaranK : This PR already has unresolved feedback from another developer. See above comment. Please resolve or respond to their feedback.

Keep in mind, I do not have time myself to review every single PR. Therefore, other developers will volunteer time for reviews/testing.

@Bhoma38 Bhoma38 closed this Aug 19, 2025
@Bhoma38 Bhoma38 deleted the feature-branch branch August 19, 2025 09:00
@github-project-automation github-project-automation bot moved this from 🙋 Needs Reviewers Assigned to ✅ Done in DSpace 10.0 Release Aug 19, 2025
@Bhoma38
Copy link
Author

Bhoma38 commented Aug 19, 2025

@kanasznagyzoltan,
We have raised another PR #4643 against the changes required.
For your reference attaching below screenshot where particular facet filter section getting highlighted to indicate value has been selected.
image

Can you please test it further and provide feedback if any?

4science-it pushed a commit to 4Science/dspace-angular that referenced this pull request Feb 5, 2026
[DSC-2703] add whitelist to DsEscapeHtml, adopt it where needed

Approved-by: Francesco Molinaro
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

1 APPROVAL pull request only requires a single approval to merge component: Discovery related to discovery search or browse system improvement

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Collapsed sidebar filter facets should indicate if a value is selected

4 participants