-
Notifications
You must be signed in to change notification settings - Fork 504
Full update pl translations and minor changes in cz and uk translations #4219
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
| "401.unauthorized": "nieautoryzowany", | ||
|
|
||
| // "403.help": "You don't have permission to access this page. You can use the button below to get back to the home page.", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@michdyk : Would it be possible to add these comments back into this file? They help with the automatic syncing between *.json5 files. One way to quickly add them back in is to run the npm run sync-i18n command, which will add these comments back into the file.
In general, while I know the comments may look odd, they are added automatically by our sync script. So, even if you remove them now, they will reappear the next time we run that command across all files (see for example #4163, which is the last time we re-synced all these translations files just before Testathon)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@tdonohue I added all comments as you asked.
tdonohue
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 Thanks @michdyk ! This looks good to me now.
References
Description
Full update of Polish translations aligned with DSpace 9.0 source and minor changes in cz and uk translations
Instructions for Reviewers
Please add a more detailed description of the changes made by your PR. At a minimum, providing a bulleted list of changes in your PR is helpful to reviewers.
List of changes in this PR:
Include guidance for how to test or review your PR. This may include: steps to reproduce a bug, screenshots or description of a new feature, or reasons behind specific changes.
Checklist
This checklist provides a reminder of what we are going to look for when reviewing your PR. You do not need to complete this checklist prior creating your PR (draft PRs are always welcome).
However, reviewers may request that you complete any actions in this list if you have not done so. If you are unsure about an item in the checklist, don't hesitate to ask. We're here to help!
mainbranch of code (unless it is a backport or is fixing an issue specific to an older branch).npm run lintnpm run check-circ-deps)package.json), I've made sure their licenses align with the DSpace BSD License based on the Licensing of Contributions documentation.