Skip to content

Conversation

@michdyk
Copy link
Contributor

@michdyk michdyk commented Apr 18, 2025

References

Description

Full update of Polish translations aligned with DSpace 9.0 source and minor changes in cz and uk translations

Instructions for Reviewers

Please add a more detailed description of the changes made by your PR. At a minimum, providing a bulleted list of changes in your PR is helpful to reviewers.

List of changes in this PR:

  • First, ...
  • Second, ...

Include guidance for how to test or review your PR. This may include: steps to reproduce a bug, screenshots or description of a new feature, or reasons behind specific changes.

Checklist

This checklist provides a reminder of what we are going to look for when reviewing your PR. You do not need to complete this checklist prior creating your PR (draft PRs are always welcome).
However, reviewers may request that you complete any actions in this list if you have not done so. If you are unsure about an item in the checklist, don't hesitate to ask. We're here to help!

  • My PR is created against the main branch of code (unless it is a backport or is fixing an issue specific to an older branch).
  • My PR is small in size (e.g. less than 1,000 lines of code, not including comments & specs/tests), or I have provided reasons as to why that's not possible.
  • My PR passes ESLint validation using npm run lint
  • My PR doesn't introduce circular dependencies (verified via npm run check-circ-deps)
  • My PR includes TypeDoc comments for all new (or modified) public methods and classes. It also includes TypeDoc for large or complex private methods.
  • My PR passes all specs/tests and includes new/updated specs or tests based on the Code Testing Guide.
  • My PR aligns with Accessibility guidelines if it makes changes to the user interface.
  • My PR uses i18n (internationalization) keys instead of hardcoded English text, to allow for translations.
  • My PR includes details on how to test it. I've provided clear instructions to reviewers on how to successfully test this fix or feature.
  • If my PR includes new libraries/dependencies (in package.json), I've made sure their licenses align with the DSpace BSD License based on the Licensing of Contributions documentation.
  • If my PR includes new features or configurations, I've provided basic technical documentation in the PR itself.
  • If my PR fixes an issue ticket, I've linked them together.

@michdyk michdyk added the i18n / l10n Internationalisation and localisation, related to message catalogs label Apr 18, 2025
@tdonohue tdonohue moved this to 🏗 In Progress in DSpace 9.0 Release Apr 18, 2025
@tdonohue tdonohue moved this from 🏗 In Progress to 🙋 Needs Reviewers Assigned in DSpace 9.0 Release Apr 18, 2025
@tdonohue tdonohue added the 1 APPROVAL pull request only requires a single approval to merge label Apr 18, 2025
"401.unauthorized": "nieautoryzowany",

// "403.help": "You don't have permission to access this page. You can use the button below to get back to the home page.",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@michdyk : Would it be possible to add these comments back into this file? They help with the automatic syncing between *.json5 files. One way to quickly add them back in is to run the npm run sync-i18n command, which will add these comments back into the file.

In general, while I know the comments may look odd, they are added automatically by our sync script. So, even if you remove them now, they will reappear the next time we run that command across all files (see for example #4163, which is the last time we re-synced all these translations files just before Testathon)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tdonohue I added all comments as you asked.

@tdonohue tdonohue added this to the 9.0 milestone Apr 21, 2025
Copy link
Member

@tdonohue tdonohue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Thanks @michdyk ! This looks good to me now.

@github-project-automation github-project-automation bot moved this from 🙋 Needs Reviewers Assigned to 👍 Reviewer Approved in DSpace 9.0 Release Apr 21, 2025
@tdonohue tdonohue merged commit b076738 into DSpace:main Apr 21, 2025
15 checks passed
@github-project-automation github-project-automation bot moved this from 👍 Reviewer Approved to ✅ Done in DSpace 9.0 Release Apr 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

1 APPROVAL pull request only requires a single approval to merge i18n / l10n Internationalisation and localisation, related to message catalogs

Projects

No open projects
Status: ✅ Done

Development

Successfully merging this pull request may close these issues.

2 participants