Skip to content

add Gujarati(gu) and marathi(mr) json5 file#4362

Merged
tdonohue merged 6 commits intoDSpace:mainfrom
GauravD2t:translation_hindi_gu_ma
Jun 2, 2025
Merged

add Gujarati(gu) and marathi(mr) json5 file#4362
tdonohue merged 6 commits intoDSpace:mainfrom
GauravD2t:translation_hindi_gu_ma

Conversation

@GauravD2t
Copy link
Copy Markdown
Contributor

@GauravD2t GauravD2t commented May 22, 2025

References

Add references/links to any related issues or PRs. These may include:

Description

add label of gujarati(gu) and marathi(Mr) Json5 file
@tdonohue

Instructions for Reviewers

Please add a more detailed description of the changes made by your PR. At a minimum, providing a bulleted list of changes in your PR is helpful to reviewers.

List of changes in this PR:

  • First, ...
  • Second, ...

Include guidance for how to test or review your PR. This may include: steps to reproduce a bug, screenshots or description of a new feature, or reasons behind specific changes.

Checklist

This checklist provides a reminder of what we are going to look for when reviewing your PR. You do not need to complete this checklist prior creating your PR (draft PRs are always welcome).
However, reviewers may request that you complete any actions in this list if you have not done so. If you are unsure about an item in the checklist, don't hesitate to ask. We're here to help!

  • My PR is created against the main branch of code (unless it is a backport or is fixing an issue specific to an older branch).
  • My PR is small in size (e.g. less than 1,000 lines of code, not including comments & specs/tests), or I have provided reasons as to why that's not possible.
  • My PR passes ESLint validation using npm run lint
  • My PR doesn't introduce circular dependencies (verified via npm run check-circ-deps)
  • My PR includes TypeDoc comments for all new (or modified) public methods and classes. It also includes TypeDoc for large or complex private methods.
  • My PR passes all specs/tests and includes new/updated specs or tests based on the Code Testing Guide.
  • My PR aligns with Accessibility guidelines if it makes changes to the user interface.
  • My PR uses i18n (internationalization) keys instead of hardcoded English text, to allow for translations.
  • My PR includes details on how to test it. I've provided clear instructions to reviewers on how to successfully test this fix or feature.
  • If my PR includes new libraries/dependencies (in package.json), I've made sure their licenses align with the DSpace BSD License based on the Licensing of Contributions documentation.
  • If my PR includes new features or configurations, I've provided basic technical documentation in the PR itself.
  • If my PR fixes an issue ticket, I've linked them together.

@GauravD2t GauravD2t changed the title add Gujarati and marathi json5 file add Gujarati(gu) and marathi(mr) json5 file May 22, 2025
@tdonohue tdonohue added i18n / l10n Internationalisation and localisation, related to message catalogs 1 APPROVAL pull request only requires a single approval to merge labels May 22, 2025
@tdonohue tdonohue moved this to 🙋 Needs Reviewers Assigned in DSpace 10.0 Release May 22, 2025
Copy link
Copy Markdown
Member

@tdonohue tdonohue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@GauravD2t : I gave these a quick test today and I cannot get them to work properly. If I select either of the two new languages in the User Interface, I get an "Internal Server Error".

I could be wrong, but it might be the name of the files. It looks like the language codes are gu and mr, but the files are named Gu.json5 (notice the capitalization) and ma.json5 (should this be mr?).

For now, unfortunately, this PR has to be moved to a future release (9.1) because it's not ready in time for 9.0.

@github-project-automation github-project-automation Bot moved this from 🙋 Needs Reviewers Assigned to 👀 Under Review in DSpace 10.0 Release May 22, 2025
@tdonohue tdonohue self-requested a review May 30, 2025 18:53
@tdonohue tdonohue added the port to dspace-9_x This PR needs to be ported to `dspace-9_x` branch for next bug-fix release label Jun 2, 2025
Copy link
Copy Markdown
Member

@tdonohue tdonohue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Thanks @GauravD2t ! I was able to re-test this today and it's now working perfectly.

@github-project-automation github-project-automation Bot moved this from 👀 Under Review to 👍 Reviewer Approved in DSpace 10.0 Release Jun 2, 2025
@tdonohue tdonohue added this to the 10.0 milestone Jun 2, 2025
@tdonohue tdonohue merged commit aa9c8ba into DSpace:main Jun 2, 2025
15 checks passed
@github-project-automation github-project-automation Bot moved this from 👍 Reviewer Approved to ✅ Done in DSpace 10.0 Release Jun 2, 2025
@dspace-bot
Copy link
Copy Markdown
Contributor

Successfully created backport PR for dspace-9_x:

@tdonohue
Copy link
Copy Markdown
Member

tdonohue commented Jun 2, 2025

NOTE: I've backported this also to the dspace-9_x branch, so that it will also be included in the 9.1 release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

1 APPROVAL pull request only requires a single approval to merge i18n / l10n Internationalisation and localisation, related to message catalogs port to dspace-9_x This PR needs to be ported to `dspace-9_x` branch for next bug-fix release

Projects

Status: ✅ Done

Development

Successfully merging this pull request may close these issues.

3 participants