add Gujarati(gu) and marathi(mr) json5 file#4362
Conversation
tdonohue
left a comment
There was a problem hiding this comment.
@GauravD2t : I gave these a quick test today and I cannot get them to work properly. If I select either of the two new languages in the User Interface, I get an "Internal Server Error".
I could be wrong, but it might be the name of the files. It looks like the language codes are gu and mr, but the files are named Gu.json5 (notice the capitalization) and ma.json5 (should this be mr?).
For now, unfortunately, this PR has to be moved to a future release (9.1) because it's not ready in time for 9.0.
tdonohue
left a comment
There was a problem hiding this comment.
👍 Thanks @GauravD2t ! I was able to re-test this today and it's now working perfectly.
|
Successfully created backport PR for |
|
NOTE: I've backported this also to the |
References
Add references/links to any related issues or PRs. These may include:
Description
add label of gujarati(gu) and marathi(Mr) Json5 file
@tdonohue
Instructions for Reviewers
Please add a more detailed description of the changes made by your PR. At a minimum, providing a bulleted list of changes in your PR is helpful to reviewers.
List of changes in this PR:
Include guidance for how to test or review your PR. This may include: steps to reproduce a bug, screenshots or description of a new feature, or reasons behind specific changes.
Checklist
This checklist provides a reminder of what we are going to look for when reviewing your PR. You do not need to complete this checklist prior creating your PR (draft PRs are always welcome).
However, reviewers may request that you complete any actions in this list if you have not done so. If you are unsure about an item in the checklist, don't hesitate to ask. We're here to help!
mainbranch of code (unless it is a backport or is fixing an issue specific to an older branch).npm run lintnpm run check-circ-deps)package.json), I've made sure their licenses align with the DSpace BSD License based on the Licensing of Contributions documentation.