Improved geospatial map bounds & scroll behaviour #4642
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
References
Description
Minor improvements regarding the geospatial map zoom & scroll behaviour.
I updated the zoom level in order to be able to zoom out more, this way you can see the whole map. Also blocked users from scrolling above the north pole and below the south pole. I also ensured that when you scroll vertically, that the points are rendered on those maps as well
Instructions for Reviewers
List of changes in this PR:
minZoomto 1 (this way you can zoom out completely, but I coudl see the point to set it to 1.5 to prevent duplicate continents from being shown)maxBounds& enforced them usingmaxBoundsViscosityto prevent scrolling out of the mapworldCopyJumpto copy the points to neighbouring maps when you scroll too far to the left/rightGuidance for how to test or review this PR.
geospatialMapViewer.enableSearchViewModetotruedcterms.spatialfield with the valuePoint ( +008.660000 +047.336111 )to a random itemChecklist
mainbranch of code (unless it is a backport or is fixing an issue specific to an older branch).npm run lintnpm run check-circ-deps)package.json), I've made sure their licenses align with the DSpace BSD License based on the Licensing of Contributions documentation.