Skip to content

Conversation

@alexandrevryghem
Copy link
Member

References

Description

Minor improvements regarding the geospatial map zoom & scroll behaviour.

I updated the zoom level in order to be able to zoom out more, this way you can see the whole map. Also blocked users from scrolling above the north pole and below the south pole. I also ensured that when you scroll vertically, that the points are rendered on those maps as well

Instructions for Reviewers

List of changes in this PR:

  • Updated the minZoom to 1 (this way you can zoom out completely, but I coudl see the point to set it to 1.5 to prevent duplicate continents from being shown)
  • Added maxBounds & enforced them using maxBoundsViscosity to prevent scrolling out of the map
  • Enabled worldCopyJump to copy the points to neighbouring maps when you scroll too far to the left/right

Guidance for how to test or review this PR.

  • Enable the map on the search page by setting geospatialMapViewer.enableSearchViewMode to true
  • Add a dcterms.spatial field with the value Point ( +008.660000 +047.336111 ) to a random item
  • Search for that item and verify the point is copied over to the neighbouring map and that the zoom functionality works as described above

Checklist

  • My PR is created against the main branch of code (unless it is a backport or is fixing an issue specific to an older branch).
  • My PR is small in size (e.g. less than 1,000 lines of code, not including comments & specs/tests), or I have provided reasons as to why that's not possible.
  • My PR passes ESLint validation using npm run lint
  • My PR doesn't introduce circular dependencies (verified via npm run check-circ-deps)
  • My PR includes TypeDoc comments for all new (or modified) public methods and classes. It also includes TypeDoc for large or complex private methods.
  • My PR passes all specs/tests and includes new/updated specs or tests based on the Code Testing Guide.
  • My PR aligns with Accessibility guidelines if it makes changes to the user interface.
  • My PR uses i18n (internationalization) keys instead of hardcoded English text, to allow for translations.
  • My PR includes details on how to test it. I've provided clear instructions to reviewers on how to successfully test this fix or feature.
  • If my PR includes new libraries/dependencies (in package.json), I've made sure their licenses align with the DSpace BSD License based on the Licensing of Contributions documentation.
  • If my PR includes new features or configurations, I've provided basic technical documentation in the PR itself.
  • If my PR fixes an issue ticket, I've linked them together.

@alexandrevryghem alexandrevryghem added this to the 10.0 milestone Aug 18, 2025
@alexandrevryghem alexandrevryghem self-assigned this Aug 18, 2025
@alexandrevryghem alexandrevryghem added the component: Discovery related to discovery search or browse system label Aug 18, 2025
@alexandrevryghem alexandrevryghem moved this to 🙋 Needs Reviewers Assigned in DSpace 10.0 Release Aug 20, 2025
@tdonohue tdonohue requested a review from kshepherd August 20, 2025 21:51
Copy link
Member

@kshepherd kshepherd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 great change, thanks @alexandrevryghem , I've tried it out and it works really well

@github-project-automation github-project-automation bot moved this from 🙋 Needs Reviewers Assigned to 👍 Reviewer Approved in DSpace 10.0 Release Aug 21, 2025
@kshepherd kshepherd added quick win Pull request is small in size & should be easy to review and/or merge 1 APPROVAL pull request only requires a single approval to merge port to dspace-9_x This PR needs to be ported to `dspace-9_x` branch for next bug-fix release labels Aug 21, 2025
@kshepherd
Copy link
Member

This is a very small change so I am merging with 1 approval

@kshepherd kshepherd merged commit f58ba03 into DSpace:main Aug 21, 2025
15 checks passed
@github-project-automation github-project-automation bot moved this from 👍 Reviewer Approved to ✅ Done in DSpace 10.0 Release Aug 21, 2025
@dspace-bot
Copy link
Contributor

Successfully created backport PR for dspace-9_x:

@tdonohue tdonohue removed the port to dspace-9_x This PR needs to be ported to `dspace-9_x` branch for next bug-fix release label Aug 21, 2025
@alexandrevryghem alexandrevryghem deleted the restrict-map-bounds_contribute-main branch August 21, 2025 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

1 APPROVAL pull request only requires a single approval to merge component: Discovery related to discovery search or browse system quick win Pull request is small in size & should be easy to review and/or merge

Projects

Status: ✅ Done

Development

Successfully merging this pull request may close these issues.

4 participants