Skip to content

Conversation

@pzlakowski
Copy link

@pzlakowski pzlakowski commented Jan 16, 2026

References

Fixes After e-person create form submission, application becomes unresponsive #5000

Description

Submission of create e-person form made application to hang and would not do any requests.

This was caused by method below:

public clearEPersonRequests(): void {
  this.getBrowseEndpoint().pipe(take(1)).subscribe((link: string) => {
    this.requestService.removeByHrefSubstring(link);
  });
}

I have correlated to use logic from bitstream.

Instructions for Reviewers

List of changes in this PR:

  • I have updated clearEPersonRequests logic to fix submission
  • I have updated test

Steps to reproduce the behaviour:

  1. Visit http://localhost:4000/access-control/epeople/create
  2. Create user
  3. E-person list will not get loaded, you cannot enter any other view e.g. Edit > Collection
  4. Redo and should work fine or visit other any page

Checklist

This checklist provides a reminder of what we are going to look for when reviewing your PR. You do not need to complete this checklist prior creating your PR (draft PRs are always welcome).
However, reviewers may request that you complete any actions in this list if you have not done so. If you are unsure about an item in the checklist, don't hesitate to ask. We're here to help!

  • My PR is created against the main branch of code (unless it is a backport or is fixing an issue specific to an older branch).
  • My PR is small in size (e.g. less than 1,000 lines of code, not including comments & specs/tests), or I have provided reasons as to why that's not possible.
  • My PR passes ESLint validation using npm run lint
  • My PR doesn't introduce circular dependencies (verified via npm run check-circ-deps)
  • My PR includes TypeDoc comments for all new (or modified) public methods and classes. It also includes TypeDoc for large or complex private methods.
  • My PR passes all specs/tests and includes new/updated specs or tests based on the Code Testing Guide.
  • My PR aligns with Accessibility guidelines if it makes changes to the user interface.
  • My PR uses i18n (internationalization) keys instead of hardcoded English text, to allow for translations.
  • My PR includes details on how to test it. I've provided clear instructions to reviewers on how to successfully test this fix or feature.
  • If my PR includes new libraries/dependencies (in package.json), I've made sure their licenses align with the DSpace BSD License based on the Licensing of Contributions documentation.
  • If my PR includes new features or configurations, I've provided basic technical documentation in the PR itself.
  • If my PR fixes an issue ticket, I've linked them together.

@tdonohue tdonohue added bug 1 APPROVAL pull request only requires a single approval to merge labels Jan 16, 2026
@tdonohue tdonohue added high priority port to dspace-9_x This PR needs to be ported to `dspace-9_x` branch for next bug-fix release labels Jan 16, 2026
@tdonohue tdonohue moved this to 🙋 Needs Reviewers Assigned in DSpace 10.0 Release Jan 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

1 APPROVAL pull request only requires a single approval to merge bug high priority port to dspace-9_x This PR needs to be ported to `dspace-9_x` branch for next bug-fix release

Projects

Status: 🙋 Needs Reviewers Assigned

Development

Successfully merging this pull request may close these issues.

After e-person create form submission, application becomes unresponsive

3 participants