Add strong warning before permanent item deletion (#5044)#5124
Merged
artlowel merged 2 commits intoDSpace:mainfrom Mar 26, 2026
Merged
Add strong warning before permanent item deletion (#5044)#5124artlowel merged 2 commits intoDSpace:mainfrom
artlowel merged 2 commits intoDSpace:mainfrom
Conversation
|
QA testing performed (no code review). Works as expected:
Does not work as expected:
|
Member
|
@alegontarz : Just for clarification. We do not require translations of every new PR. So, I'm going to consider your review as an "approval" that this PR is working. Translations always occur later (usually during Testathon) by translators. |
|
Hi @guillermo-escire, just tested this and everything looks great. Just one small suggestion: to maintain consistency, would it be possible to flip the buttons in the modal? Currently, the main screen presents "Delete" (left) and "Cancel" (right). The modal presents "Delete" (right) and "Cancel" (left). See screenshot.
|
artlowel
approved these changes
Mar 26, 2026
Member
artlowel
left a comment
There was a problem hiding this comment.
Thanks @guillermo-escire!
The code looks good, and it works.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

References
Fixes #5044
Description
Adds a stronger confirmation dialog before permanently deleting an item, warning administrators about irreversible deletion and potential impact on citations and external references.
Instructions for Reviewers
This PR improves the deletion workflow for items by adding a stronger confirmation dialog before permanent deletion.
List of changes in this PR:
How to test:
Checklist
This checklist provides a reminder of what we are going to look for when reviewing your PR. You do not need to complete this checklist prior creating your PR (draft PRs are always welcome).
However, reviewers may request that you complete any actions in this list if you have not done so. If you are unsure about an item in the checklist, don't hesitate to ask. We're here to help!
mainbranch of code (unless it is a backport or is fixing an issue specific to an older branch).npm run lintnpm run check-circ-deps)package.json), I've made sure their licenses align with the DSpace BSD License based on the Licensing of Contributions documentation.