Skip to content

fix: prevent drop files overlay from appearing when dragging text#5312

Open
oscar-escire wants to merge 1 commit intoDSpace:mainfrom
oscar-escire:Issue/1268
Open

fix: prevent drop files overlay from appearing when dragging text#5312
oscar-escire wants to merge 1 commit intoDSpace:mainfrom
oscar-escire:Issue/1268

Conversation

@oscar-escire
Copy link
Contributor

References

Description

Prevent the "drop files" overlay from appearing when dragging text selections in Firefox on submission pages.

List of changes in this PR:

  • Added dataTransfer.types.includes('Files') guard in UploaderComponent.onDragOver() (uploader.component.ts)
  • Added the same guard in FileDropzoneNoUploaderComponent.onDragOver() (file-dropzone-no-uploader.component.ts)

Instructions for Reviewers

  1. Open the application in Firefox
  2. Navigate to a new submission or edit a workspace item
  3. Select some text on the page
  4. Drag the text selection around the page
  5. Expected: The "Drop files" overlay should NOT appear
  6. Now drag an actual file from your file explorer onto the page
  7. Expected: The "Drop files" overlay should appear as normal

Checklist

  • My PR is created against the main branch of code (unless it is a backport or is fixing an issue specific to an older branch).
  • My PR is small in size (e.g. less than 1,000 lines of code, not including comments & specs/tests), or I have provided reasons as to why that's not possible.
  • My PR passes ESLint validation using npm run lint
  • My PR doesn't introduce circular dependencies (verified via npm run check-circ-deps)
  • My PR includes TypeDoc comments for all new (or modified) public methods and classes. It also includes TypeDoc for large or complex private methods.
  • My PR passes all specs/tests and includes new/updated specs or tests based on the Code Testing Guide.
  • My PR aligns with Accessibility guidelines if it makes changes to the user interface.
  • My PR uses i18n (internationalization) keys instead of hardcoded English text, to allow for translations.
  • My PR includes details on how to test it. I've provided clear instructions to reviewers on how to successfully test this fix or feature.
  • If my PR includes new libraries/dependencies (in package.json), I've made sure their licenses align with the DSpace BSD License based on the Licensing of Contributions documentation.
  • If my PR includes new features or configurations, I've provided basic technical documentation in the PR itself.
  • If my PR fixes an issue ticket, I've linked them together.

@lgeggleston lgeggleston added bug usability component: submission port to dspace-8_x This PR needs to be ported to `dspace-8_x` branch for next bug-fix release port to dspace-9_x This PR needs to be ported to `dspace-9_x` branch for next bug-fix release labels Mar 26, 2026
@lgeggleston lgeggleston moved this to 👀 Under Review in DSpace 10.0 Release Mar 26, 2026
@lgeggleston lgeggleston moved this from 👀 Under Review to 🙋 Needs Reviewers Assigned in DSpace 10.0 Release Mar 26, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug component: submission port to dspace-8_x This PR needs to be ported to `dspace-8_x` branch for next bug-fix release port to dspace-9_x This PR needs to be ported to `dspace-9_x` branch for next bug-fix release usability

Projects

Status: 🙋 Needs Reviewers Assigned

Development

Successfully merging this pull request may close these issues.

Dragging text selection over submission form triggers "drop files" message

2 participants