Skip to content

[Port dspace-8_x] Remove axios dependency#5347

Merged
tdonohue merged 1 commit into
DSpace:dspace-8_xfrom
alanorth:remove-axios-dspace-8x
Apr 1, 2026
Merged

[Port dspace-8_x] Remove axios dependency#5347
tdonohue merged 1 commit into
DSpace:dspace-8_xfrom
alanorth:remove-axios-dspace-8x

Conversation

@alanorth
Copy link
Copy Markdown
Contributor

@alanorth alanorth commented Apr 1, 2026

References

Description

We can use the Node.js Fetch API directly instead of relying on an external dependency. As of Node.js v20 the Fetch API is mature and we don't need to rely on Axios. This is even more relevant because Axios was compromised this week.

Note: this is unneeded on dspace-9_x and main because we already did as part of #4632.

Instructions for Reviewers

Please add a more detailed description of the changes made by your PR. At a minimum, providing a bulleted list of changes in your PR is helpful to reviewers.

List of changes in this PR:

  • First, remove Axios dependency and replace with native fetch
  • Second, run yarn install to update package lockfile

Include guidance for how to test or review your PR. This may include: steps to reproduce a bug, screenshots or description of a new feature, or reasons behind specific changes.

Make sure all tests in CI pass. Make sure the application builds and runs in production mode.

Checklist

This checklist provides a reminder of what we are going to look for when reviewing your PR. You do not need to complete this checklist prior creating your PR (draft PRs are always welcome).
However, reviewers may request that you complete any actions in this list if you have not done so. If you are unsure about an item in the checklist, don't hesitate to ask. We're here to help!

  • My PR is created against the main branch of code (unless it is a backport or is fixing an issue specific to an older branch).
  • My PR is small in size (e.g. less than 1,000 lines of code, not including comments & specs/tests), or I have provided reasons as to why that's not possible.
  • My PR passes ESLint validation using npm run lint
  • My PR doesn't introduce circular dependencies (verified via npm run check-circ-deps)
  • My PR includes TypeDoc comments for all new (or modified) public methods and classes. It also includes TypeDoc for large or complex private methods.
  • My PR passes all specs/tests and includes new/updated specs or tests based on the Code Testing Guide.
  • My PR aligns with Accessibility guidelines if it makes changes to the user interface.
  • My PR uses i18n (internationalization) keys instead of hardcoded English text, to allow for translations.
  • My PR includes details on how to test it. I've provided clear instructions to reviewers on how to successfully test this fix or feature.
  • If my PR includes new libraries/dependencies (in package.json), I've made sure their licenses align with the DSpace BSD License based on the Licensing of Contributions documentation.
  • If my PR includes new features or configurations, I've provided basic technical documentation in the PR itself.
  • If my PR fixes an issue ticket, I've linked them together.

We can use the Node.js Fetch API directly instead of relying on an
external dependency.
@alanorth alanorth added dependencies Pull requests that update a dependency file 1 APPROVAL pull request only requires a single approval to merge labels Apr 1, 2026
@alanorth alanorth mentioned this pull request Apr 1, 2026
12 tasks
@alanorth alanorth changed the title Remove axios dependency [dspace-8_x] Remove axios dependency Apr 1, 2026
@lgeggleston lgeggleston moved this to 🙋 Needs Reviewers Assigned in DSpace Maintenance (9.x, 8.x, 7.6.x) Apr 1, 2026
@lgeggleston lgeggleston added this to the 8.4 milestone Apr 1, 2026
@tdonohue tdonohue changed the title [dspace-8_x] Remove axios dependency [Port dspace-8_x] Remove axios dependency Apr 1, 2026
Copy link
Copy Markdown
Member

@tdonohue tdonohue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Thanks @alanorth ! I've verified these are the same Axios-related changes previously made on dspace-9_x and main via #4632.

@github-project-automation github-project-automation Bot moved this from 🙋 Needs Reviewers Assigned to 👍 Reviewer Approved in DSpace Maintenance (9.x, 8.x, 7.6.x) Apr 1, 2026
@tdonohue tdonohue merged commit b7e4f21 into DSpace:dspace-8_x Apr 1, 2026
16 checks passed
@github-project-automation github-project-automation Bot moved this from 👍 Reviewer Approved to ✅ Done in DSpace Maintenance (9.x, 8.x, 7.6.x) Apr 1, 2026
@alanorth alanorth deleted the remove-axios-dspace-8x branch April 1, 2026 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

1 APPROVAL pull request only requires a single approval to merge dependencies Pull requests that update a dependency file

Projects

Development

Successfully merging this pull request may close these issues.

3 participants