Missing german i18n translations.#5403
Merged
tdonohue merged 1 commit intoDSpace:mainfrom Apr 7, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR includes the missing german i18n translations.
Instructions for Reviewers
Based on the Comments introduced in dd0d7e0, this PR updated the de.json5 in order to add all missing german translations and removed the corresponding TODOs.
List of changes in this PR:
Include guidance for how to test or review your PR. This may include: steps to reproduce a bug, screenshots or description of a new feature, or reasons behind specific changes.
Checklist
This checklist provides a reminder of what we are going to look for when reviewing your PR. You do not need to complete this checklist prior creating your PR (draft PRs are always welcome).
However, reviewers may request that you complete any actions in this list if you have not done so. If you are unsure about an item in the checklist, don't hesitate to ask. We're here to help!
mainbranch of code (unless it is a backport or is fixing an issue specific to an older branch).npm run lintMy PR doesn't introduce circular dependencies (verified vianpm run check-circ-deps)My PR includes TypeDoc comments for all new (or modified) public methods and classes. It also includes TypeDoc for large or complex private methods.My PR passes all specs/tests and includes new/updated specs or tests based on the Code Testing Guide.My PR includes details on how to test it. I've provided clear instructions to reviewers on how to successfully test this fix or feature.If my PR includes new libraries/dependencies (inpackage.json), I've made sure their licenses align with the DSpace BSD License based on the Licensing of Contributions documentation.If my PR includes new features or configurations, I've provided basic technical documentation in the PR itself.If my PR fixes an issue ticket, I've linked them together.