Skip to content

[Port dspace-8_x] Remove unused dependencies#5446

Merged
tdonohue merged 3 commits intoDSpace:dspace-8_xfrom
tdonohue:port_4783_to_8x
Apr 8, 2026
Merged

[Port dspace-8_x] Remove unused dependencies#5446
tdonohue merged 3 commits intoDSpace:dspace-8_xfrom
tdonohue:port_4783_to_8x

Conversation

@tdonohue
Copy link
Copy Markdown
Member

@tdonohue tdonohue commented Apr 8, 2026

References

Description

This PR is a backport of #4738 by @alanorth to the dspace-8_x branch. I decided to backport this original PR to avoid dependabot PRs related to these unused dependencies.

It only removes three of the unused dependencies which were verified as unused on the dspace-8_x branch using Knip (similar to the original PR)

  • Remove @babel/runtime from package.json
  • Remove webpack-dev-server from package.json
  • Remove @angular/language-service from package.json

After removing all dependencies, I reran yarn run clean and yarn install to verify the lock file was updated properly.

Instructions for Reviewers

  • Verify tests pass
  • Verify no change in behavior in dev and production mode

@tdonohue tdonohue added this to the 8.4 milestone Apr 8, 2026
@tdonohue tdonohue added dependencies Pull requests that update a dependency file 1 APPROVAL pull request only requires a single approval to merge labels Apr 8, 2026
@tdonohue tdonohue mentioned this pull request Apr 8, 2026
12 tasks
@tdonohue tdonohue moved this to 🙋 Needs Reviewers Assigned in DSpace Maintenance (9.x, 8.x, 7.6.x) Apr 8, 2026
@tdonohue
Copy link
Copy Markdown
Member Author

tdonohue commented Apr 8, 2026

👍 Verified no change in behavior on the dspace-8_x branch when running in either production or developer mode.

@tdonohue
Copy link
Copy Markdown
Member Author

tdonohue commented Apr 8, 2026

I've tested this backport locally & found no issues with starting the 8.x UI in either dev or production mode. Merging immediately.

@tdonohue tdonohue merged commit a614f7a into DSpace:dspace-8_x Apr 8, 2026
17 of 19 checks passed
@github-project-automation github-project-automation Bot moved this from 🙋 Needs Reviewers Assigned to ✅ Done in DSpace Maintenance (9.x, 8.x, 7.6.x) Apr 8, 2026
@tdonohue tdonohue deleted the port_4783_to_8x branch April 8, 2026 17:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

1 APPROVAL pull request only requires a single approval to merge dependencies Pull requests that update a dependency file

Projects

Development

Successfully merging this pull request may close these issues.

1 participant