Skip to content

[Port dspace-9_x] updates ORCID icon and link displays according to their guidelines#5515

Merged
tdonohue merged 4 commits intoDSpace:dspace-9_xfrom
TexasDigitalLibrary:DS-4766-port_to_9x
Apr 21, 2026
Merged

[Port dspace-9_x] updates ORCID icon and link displays according to their guidelines#5515
tdonohue merged 4 commits intoDSpace:dspace-9_xfrom
TexasDigitalLibrary:DS-4766-port_to_9x

Conversation

@nwoodward
Copy link
Copy Markdown
Contributor

@nwoodward nwoodward commented Apr 20, 2026

References

Description

See original PR for details.

Instructions for Reviewers

Please add a more detailed description of the changes made by your PR. At a minimum, providing a bulleted list of changes in your PR is helpful to reviewers.

List of changes in this PR:

  • First, ...
  • Second, ...

Include guidance for how to test or review your PR. This may include: steps to reproduce a bug, screenshots or description of a new feature, or reasons behind specific changes.

Checklist

This checklist provides a reminder of what we are going to look for when reviewing your PR. You do not need to complete this checklist prior creating your PR (draft PRs are always welcome).
However, reviewers may request that you complete any actions in this list if you have not done so. If you are unsure about an item in the checklist, don't hesitate to ask. We're here to help!

  • My PR is created against the main branch of code (unless it is a backport or is fixing an issue specific to an older branch).
  • My PR is small in size (e.g. less than 1,000 lines of code, not including comments & specs/tests), or I have provided reasons as to why that's not possible.
  • My PR passes ESLint validation using npm run lint
  • My PR doesn't introduce circular dependencies (verified via npm run check-circ-deps)
  • My PR includes TypeDoc comments for all new (or modified) public methods and classes. It also includes TypeDoc for large or complex private methods.
  • My PR passes all specs/tests and includes new/updated specs or tests based on the Code Testing Guide.
  • My PR aligns with Accessibility guidelines if it makes changes to the user interface.
  • My PR uses i18n (internationalization) keys instead of hardcoded English text, to allow for translations.
  • My PR includes details on how to test it. I've provided clear instructions to reviewers on how to successfully test this fix or feature.
  • If my PR includes new libraries/dependencies (in package.json), I've made sure their licenses align with the DSpace BSD License based on the Licensing of Contributions documentation.
  • If my PR includes new features or configurations, I've provided basic technical documentation in the PR itself.
  • If my PR fixes an issue ticket, I've linked them together.

@lgeggleston lgeggleston added bug integration: ORCID Related to integration with ORCID identifier system labels Apr 21, 2026
@lgeggleston lgeggleston moved this to 👍 Reviewer Approved in DSpace Maintenance (9.x, 8.x, 7.6.x) Apr 21, 2026
@lgeggleston lgeggleston added this to the 9.3 milestone Apr 21, 2026
@lgeggleston lgeggleston changed the title [Backport dspace-9_x] updates ORCID icon and link displays according to their guidelines [Port dspace-9_x] updates ORCID icon and link displays according to their guidelines Apr 21, 2026
Copy link
Copy Markdown
Member

@tdonohue tdonohue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Thanks @nwoodward ! I've verified this is an accurate port of #5489.

@tdonohue tdonohue merged commit 945e14b into DSpace:dspace-9_x Apr 21, 2026
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug integration: ORCID Related to integration with ORCID identifier system

Projects

Development

Successfully merging this pull request may close these issues.

3 participants