fix #5542: display Primary badge on Download button component for pri…

[guillermo-escire]

References

• Fixes Download button rendering on item page does not label Primary bitstream #5542

Description

Adds the "Primary" badge to the Download button component so users can identify the primary bitstream on the item page when showDownloadLinkAsAttachment is enabled.

Instructions for Reviewers

List of changes in this PR:

• Added @input() primaryBitstreamId: string to BitstreamAttachmentComponent
• Added the Primary badge in bitstream-attachment.component.html next to the Download button
• Passed primaryBitstreamId from AttachmentSectionComponent (which already inherits it from FileSectionComponent) down to BitstreamAttachmentComponent
• Added unit tests to verify the badge displays correctly

How to test:

1. In config/config.yml, set layout.showDownloadLinkAsAttachment: true
2. Go to an item with multiple files where one is marked as Primary
3. Confirm the Primary badge appears next to the correct Download button
4. Confirm no badge appears on the non-primary file

Checklist

This checklist provides a reminder of what we are going to look for when reviewing your PR. You do not need to complete this checklist prior creating your PR (draft PRs are always welcome).
However, reviewers may request that you complete any actions in this list if you have not done so. If you are unsure about an item in the checklist, don't hesitate to ask. We're here to help!

• My PR is created against the main branch of code (unless it is a backport or is fixing an issue specific to an older branch).
• My PR is small in size (e.g. less than 1,000 lines of code, not including comments & specs/tests), or I have provided reasons as to why that's not possible.
• My PR passes ESLint validation using npm run lint
• My PR doesn't introduce circular dependencies (verified via npm run check-circ-deps)
• My PR includes TypeDoc comments for all new (or modified) public methods and classes. It also includes TypeDoc for large or complex private methods.
• My PR passes all specs/tests and includes new/updated specs or tests based on the Code Testing Guide.
• My PR aligns with Accessibility guidelines if it makes changes to the user interface.
• My PR uses i18n (internationalization) keys instead of hardcoded English text, to allow for translations.
• My PR includes details on how to test it. I've provided clear instructions to reviewers on how to successfully test this fix or feature.
• If my PR includes new libraries/dependencies (in package.json), I've made sure their licenses align with the DSpace BSD License based on the Licensing of Contributions documentation.
• If my PR includes new features or configurations, I've provided basic technical documentation in the PR itself.
• If my PR fixes an issue ticket, I've linked them together.

[lgeggleston]

@guillermo-escire thanks for the quick work on this!

@FrancescoMolinaro given your familiarity with this component from the original port, would you be comfortable giving this a review if you have time? Thank you!

[FrancescoMolinaro]

Hi @guillermo-escire , many thanks for your work on this, I tested the improvment and it works as expected, the only thing I am not convinced about is the positioning of the badge, the template is currently divided in three columns and I think would be best to keep the badge in one of the columns, without stretching them, something like:

In this way we would have more space for the metadata information to be desplayed entirely.
Or do you think could represent an issue? Otherwise I am a +1 on this, thanks again for the PR.

[guillermo-escire]

Hi @FrancescoMolinaro, thanks for the feedback! I've updated the badge positioning to keep it within the right column, below the Download button, as you suggested. This avoids stretching the layout and keeps the metadata column with enough space. Please let me know if this looks good to you!