Skip to content

fix: the editor content incorrect when changing tabs#210

Merged
wewoor merged 1 commit intomainfrom
fix/editor
Jun 29, 2021
Merged

fix: the editor content incorrect when changing tabs#210
wewoor merged 1 commit intomainfrom
fix/editor

Conversation

@mortalYoung
Copy link
Copy Markdown
Collaborator

@mortalYoung mortalYoung commented Jun 29, 2021

简介

  • 修复 editor 切换 tabs 的时候,editor 的内容变更不正确的问题

主要变更

  • 主要问题在于在给每一个 tab 创建 model 的时候,会调用 this.openFile 而打开新文件和切换 tab 的时候该方法的 path 参数穿的值不一样,导致后续的一系列不正确的问题

Related Issues

Closed #145

@wewoor wewoor linked an issue Jun 29, 2021 that may be closed by this pull request
@wewoor wewoor requested a review from mumiao June 29, 2021 09:56
@wewoor wewoor added the bug Something isn't working label Jun 29, 2021
@wewoor wewoor added this to the 0.9.0-alpha.3 milestone Jun 29, 2021
@wewoor wewoor merged commit 7d59c07 into main Jun 29, 2021
@wewoor wewoor deleted the fix/editor branch June 29, 2021 11:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

The Code Editor content is wrong when EditorTabs are changed.

2 participants