Skip to content

fix: declare the useEffect before return #808

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
wewoor merged 1 commit into from
Sep 29, 2022
Merged

fix: declare the useEffect before return #808

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
38 changes: 19 additions & 19 deletions src/workbench/sidebar/explore/folderTree.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,25 +90,6 @@ const FolderTree: React.FunctionComponent<IFolderTreeProps> = (props) => {
current,
} = folderTree;

const handleAddRootFolder = () => {
createTreeNode?.('RootFolder');
};

const welcomePage = (
<div data-content={panel.id}>
{entry ? (
<>{entry}</>
) : (
<div style={{ padding: '10px 5px' }}>
you have not yet opened a folder
<Button onClick={handleAddRootFolder}>Add Folder</Button>
</div>
)}
</div>
);

if (!data.length) return welcomePage;

const inputRef = useRef<HTMLInputElement>(null);
// tree context view
const contextMenu = useRef<ReturnType<typeof useContextMenu>>();
Expand Down Expand Up @@ -221,6 +202,10 @@ const FolderTree: React.FunctionComponent<IFolderTreeProps> = (props) => {
onDropTree?.(source, target);
};

const handleAddRootFolder = () => {
createTreeNode?.('RootFolder');
};

useEffect(() => {
if (folderPanelContextMenu.length > 0) {
contextMenu.current = initContextMenu();
Expand All @@ -230,6 +215,21 @@ const FolderTree: React.FunctionComponent<IFolderTreeProps> = (props) => {
};
}, [data.length]);

const welcomePage = (
<div data-content={panel.id}>
{entry ? (
<>{entry}</>
) : (
<div style={{ padding: '10px 5px' }}>
you have not yet opened a folder
<Button onClick={handleAddRootFolder}>Add Folder</Button>
</div>
)}
</div>
);

if (!data.length) return welcomePage;

return (
<Scrollable noScrollX isShowShadow>
<div data-content={panel.id} style={{ height: '100%' }}>
Expand Down