fix(evm): block gas limit overflow#566
Open
ys8888john wants to merge 1 commit into
Open
Conversation
Clamp block_gas_limit, block_number, and block_timestamp to INT64_MAX when their JSON values in loadState() exceed INT64_MAX, instead of silently wrapping to negative int64_t values. Previously, IsUint64()/GetUint64() accepted values in [2^63, 2^64-1] which silently overflowed when assigned to int64_t fields. Now values exceeding INT64_MAX are clamped to INT64_MAX, ensuring the stored value is always non-negative and within the valid int64_t range. Closes DTVMStack#563, Closes DTVMStack#564 Co-Authored-By: Claude <noreply@anthropic.com>
⚡ Performance Regression Check Results✅ Performance Check Passed (interpreter)Performance Benchmark Results (threshold: 25%)
Summary: 194 benchmarks, 0 regressions ✅ Performance Check Passed (multipass)Performance Benchmark Results (threshold: 25%)
Summary: 194 benchmarks, 0 regressions |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Clamp block_gas_limit, block_number, and block_timestamp to INT64_MAX when their JSON values in loadState() exceed INT64_MAX, instead of silently wrapping to negative int64_t values.
Previously, IsUint64()/GetUint64() accepted values in [2^63, 2^64-1] which silently overflowed when assigned to int64_t fields. Now values exceeding INT64_MAX are clamped to INT64_MAX, ensuring the stored value is always non-negative and within the valid int64_t range.
Closes #563, Closes #564
1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):
fix #563 , re #564 ,
2. What is the scope of this PR (e.g. component or file name):
3. Provide a description of the PR(e.g. more details, effects, motivations or doc link):
4. Are there any breaking changes?(Y/N) and describe the breaking changes(e.g. more details, motivations or doc link):
5. Are there test cases for these changes?(Y/N) select and add more details, references or doc links:
6. Release note