Introduce machinery to handle multiple Handler streams, and parsing handler configurations from OKS #24
Merged
Merged
Conversation
emmuhamm
commented
Jan 15, 2026
Collaborator
Author
|
@PawelPlesniak This, and the sister PR DUNE-DAQ/erskafka#43 is ready for review. Theres a few things I've highlighted here that I think we should discuss, but the general implementation should be ready for you to go through Let me know what you think :) |
emmuhamm
commented
Jan 19, 2026
emmuhamm
commented
Jan 21, 2026
emmuhamm
commented
Feb 2, 2026
Collaborator
|
Once done with comments in code, I will re-read, will choose |
emmuhamm
commented
Feb 2, 2026
Collaborator
|
Also please do not forget to run the following prior to completing this The format will fix your indents, and the check will tell you things like missing args |
Collaborator
|
LGTM, structure is sound and the implementation works as intended, but OpMon requires removal |
Collaborator
Note for future reviewersThe OpMon implementation is correct to have a protobuf handler, but has not yet been finished - there will be a future PR associated with the listed issue. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Close #35
Needs to go in with DUNE-DAQ/erskafka#43
To fully implement ERS into drunc, some machinery is required to be introduced to the logging infrastructure in the Python implementation of the DUNEDAQ.
This PR adds several things
Full information the logic behind this is described in the logging page in the drunc wiki
A full demonstration of how this works in practice is found in the demonstration python script that has been updated as part of this PR.
Testing instructions for review
NFD_DEV_260109_A9) and check out this branch and Update handlers in preparation for introducing ERS to drunc erskafka#43.daqpytools-logging-demonstrator -r -f logger.log --handlertypesType of change
Testing checklist
dbt-build --unittest)pytest -s minimal_system_quick_test.py)daqsystemtest_integtest_bundle.sh)python -m pytest)pre-commit run --all-files)Comments here on the testing
Further checks
dbt-build --lint, and/or see https://dune-daq-sw.readthedocs.io/en/latest/packages/styleguide/)(Indicate issue here: # (issue))
FOLLOW UP
TODOs: