Skip to content

Updates for DAPHNEEth readout type scan test using asset file - #344

Merged
wesketchum merged 4 commits into
developfrom
sbhuller/pds-eth-conf
Sep 2, 2026
Merged

Updates for DAPHNEEth readout type scan test using asset file#344
wesketchum merged 4 commits into
developfrom
sbhuller/pds-eth-conf

Conversation

@wesketchum

@wesketchum wesketchum commented Aug 31, 2026

Copy link
Copy Markdown
Contributor

Description

Addresses issue #263 by introducing the use of a DAPHNEEth asset file in readout_type_scan.

Requires PRs from daqconf and fdreadoutlibs, and should also have fdreadoutmodules pulled down for testing. A yaml recipe file is

recipe_name: fake-pds-eth-conf
daq_release: NFD_DEV_260831_A9
daq_release_type: nightly
repos:
- name: daqsystemtest
  ref: sbhuller/pds-eth-conf
  ref_valid: true
  commit: 230eb717bb6e9c56aeec162ac6fecbaad2ee6790
  commit_valid: true
- name: daqconf
  ref: wketchu/pds-eth-conf
  ref_valid: true
  commit: a5dd792e14b5acf8b06d23efb0b38cda6fceb324
  commit_valid: true
- name: fdreadoutmodules
  ref: develop
  ref_valid: true
  commit: 9497e98dcc8048f3f4c87e2809e1a3827fe1a46c
  commit_valid: true
- name: fdreadoutlibs
  ref: wketchu/pds-eth-conf
  ref_valid: true
  commit: 3fedaa6d0207ca6772fe299fac2d42959c84cb73
  commit_valid: true

If that is copied into a fake-pds-eth-conf.yaml file, then after setting up dbt,

dbtx-create-workarea-from-recipe.py --use-ref fake-pds-eth-conf.yaml

will create a working area. After builidng/setting up, test by doing

daqsystemtest_integtest_bundle.sh -k readout_type_scan

and should see the DAPHNEEth test passes.

Type of change

  • Documentation (non-breaking change that adds or improves the documentation)
  • New feature or enhancement (non-breaking change which adds functionality)
  • Optimization (non-breaking change that improves code/performance)
  • Bug fix (non-breaking change which fixes an issue)
  • Breaking change (whatever its nature)

Testing checklist

  • Unit tests pass (e.g. dbt-build --unittest)
  • Minimal system quicktest passes (pytest -s minimal_system_quick_test.py)
  • Full set of integration tests pass (dunedaq_integtest_bundle.sh)
  • Python tests pass if applicable (e.g. python -m pytest)
  • Pre-commit hooks run successfully if applicable (e.g. pre-commit run --all-files)

Further checks

  • Code is commented where needed, particularly in hard-to-understand areas
  • Code style is correct (dbt-build --lint, and/or see https://dune-daq-sw.readthedocs.io/en/latest/packages/styleguide/)
  • If applicable, new tests have been added or an issue has been opened to tackle that in the future.
    (Indicate issue here: # (issue))

@bieryAtFnal bieryAtFnal left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks reasonable to me. I've confirmed that the readout_type_scan_test continues to run fine with these changes. And, config diagrams generated from the integtest config for the DAPHNEEth part of the RTST show the expected difference. I'm a little surprised that the size of the DAPHNEEth fragments are very similar before and after these changes, but maybe that is just based on good tuning of the tick difference.

@wesketchum

Copy link
Copy Markdown
Contributor Author

I expect it comes down to the similarity of the setup of the distributions of the timestamps between the purely fake data mode and the data pulled from the asset file.

@wesketchum
wesketchum merged commit 4760362 into develop Sep 2, 2026
6 checks passed
@wesketchum
wesketchum deleted the sbhuller/pds-eth-conf branch September 2, 2026 12:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants