Updates for DAPHNEEth readout type scan test using asset file - #344
Merged
Conversation
This was referenced Aug 31, 2026
bieryAtFnal
approved these changes
Sep 1, 2026
bieryAtFnal
left a comment
Collaborator
There was a problem hiding this comment.
This looks reasonable to me. I've confirmed that the readout_type_scan_test continues to run fine with these changes. And, config diagrams generated from the integtest config for the DAPHNEEth part of the RTST show the expected difference. I'm a little surprised that the size of the DAPHNEEth fragments are very similar before and after these changes, but maybe that is just based on good tuning of the tick difference.
Contributor
Author
|
I expect it comes down to the similarity of the setup of the distributions of the timestamps between the purely fake data mode and the data pulled from the asset file. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Addresses issue #263 by introducing the use of a DAPHNEEth asset file in readout_type_scan.
Requires PRs from daqconf and fdreadoutlibs, and should also have
fdreadoutmodulespulled down for testing. A yaml recipe file isIf that is copied into a
fake-pds-eth-conf.yamlfile, then after setting up dbt,will create a working area. After builidng/setting up, test by doing
and should see the DAPHNEEth test passes.
Type of change
Testing checklist
dbt-build --unittest)pytest -s minimal_system_quick_test.py)dunedaq_integtest_bundle.sh)python -m pytest)pre-commit run --all-files)Further checks
dbt-build --lint, and/or see https://dune-daq-sw.readthedocs.io/en/latest/packages/styleguide/)(Indicate issue here: # (issue))