Skip to content

[K8s] Fix for restart case - #596

Merged
wanyunSu merged 2 commits into
developfrom
mrigan/k8s_restart_fix
Sep 30, 2025
Merged

[K8s] Fix for restart case#596
wanyunSu merged 2 commits into
developfrom
mrigan/k8s_restart_fix

Conversation

@MRiganSUSX

Copy link
Copy Markdown
Contributor

Description

Fixes #589

When restarting, there is no native event that flags that the pod was deleted AND the resources (such as the name of the pod) cleaned up completely. Therefore we need to watch for notify on DELETED state + wait for the cleanup. There is an associated error code for the 'name still in use' so we use that as a flag.

Type of change

  • Documentation (non-breaking change that adds or improves the documentation)
  • New feature (non-breaking change which adds functionality)
  • Optimization (non-breaking, back-end change that speeds up the code)
  • Bug fix (non-breaking change which fixes an issue)
  • Breaking change (whatever its nature)

Key checklist

  • All tests pass (eg. python -m pytest)
  • Pre-commit hooks run successfully (eg. pre-commit run --all-files)

Further checks

  • Code is commented, particularly in hard-to-understand areas
  • Tests added or an issue has been opened to tackle that in the future.
    (Indicate issue here: # (issue))

@MRiganSUSX
MRiganSUSX requested a review from wanyunSu September 30, 2025 10:03
@MRiganSUSX

Copy link
Copy Markdown
Contributor Author

Apologies for the big number of (apparent) changes, that is the result of ruff.

The important change is in create_pod for restart case.

@wanyunSu wanyunSu left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested with MSQT, passed

@wanyunSu
wanyunSu merged commit adfe4e8 into develop Sep 30, 2025
3 checks passed
@wanyunSu
wanyunSu deleted the mrigan/k8s_restart_fix branch September 30, 2025 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: k8s : kill_impl doesn't really delete the pods

3 participants