[K8s] Fix for restart case - #596
Merged
Merged
Conversation
Contributor
Author
|
Apologies for the big number of (apparent) changes, that is the result of ruff. The important change is in create_pod for restart case. |
8 tasks
wanyunSu
approved these changes
Sep 30, 2025
wanyunSu
left a comment
Contributor
There was a problem hiding this comment.
Tested with MSQT, passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #589
When restarting, there is no native event that flags that the pod was deleted AND the resources (such as the name of the pod) cleaned up completely. Therefore we need to watch for notify on DELETED state + wait for the cleanup. There is an associated error code for the 'name still in use' so we use that as a flag.
Type of change
Key checklist
python -m pytest)pre-commit run --all-files)Further checks
(Indicate issue here: # (issue))