K8s : add settings to the PM config - #602
Merged
Merged
Conversation
8 tasks
wanyunSu
marked this pull request as ready for review
October 9, 2025 09:38
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the K8s process manager configuration to make use of a structured settings configuration instead of hardcoded values and flat configuration access. The changes introduce a hierarchical settings structure that organizes configuration parameters into logical groups (labels, connection_server, pod_management, cleanup, checking) and makes several timeout and retry values configurable.
Key changes:
- Restructured configuration access to use nested settings groups instead of flat key-value pairs
- Made hardcoded sleep values configurable through the settings
- Updated connection URL logging to use pod IP instead of hostname
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| src/drunc/process_manager/k8s_process_manager.py | Refactored configuration loading to use structured settings and made sleep/timeout values configurable |
| src/drunc/data/process_manager/k8s.json | Added structured settings configuration with organized parameter groups |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Contributor
|
Hi @wanyunSu,
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Make use of process manager configuration for k8s settings
Type of change
Key checklist
python -m pytest)pre-commit run --all-files)Further checks
(Indicate issue here: # (issue))