Per-series color & dashed line style for ui_line_chart - #154
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #137
What
Adds per-series styling to
ui_line_chartso overlaid lines (e.g. current vs previous period) are visually distinguishable.A series entry now accepts two optional keys:
color:— any CSS color, or an accent token likevar(--color-accent-500).dashed:—truerenders a dashed line (borderDash: [6, 6]).Notes
{ name:, data: }series produces the exact same dataset as before; the styling keys are only added when present.var(--color-...)strings, so theline-chartcontroller resolves CSS custom-propertyborderColors to concrete values at connect time. This lets the accent/surface color system drive line colors.the_locallocals rebuilt (rake the_local:build).Tests
color:→ datasetborderColor.dashed: true→ datasetborderDash.🤖 Generated with Claude Code