Fix nav dropdown bare link_to children rendering inline - #155
Merged
Conversation
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ui_nav_dropdown's documented API passes barelink_tochildren (direct<a>children, not wrapped inul/li). But.nav-dropdown-menuonly styledli a, so bare anchors got nodisplay:block/padding and rendered inline — running together and wrapping (e.g. "Biz Owner Sales Associate Fulfillment").Changes (CSS only)
& > a) alongsideli ain.nav-dropdown-menu, so the documented bare-link_tousage renders as proper stacked rows.white-space: nowrapso menu items don't wrap.POST items (
link_to label, path, data: { turbo_method: :post }) render an<a>, so this fix covers persona sign-in / sign-out / impersonation links too.Testing
test/keystone/nav_css_test.rb(two new assertions, one per behavior, TDD).428 runs, 1122 assertions, 0 failures.Closes #139
🤖 Generated with Claude Code