Migrate to the manifest-based the_local provider model - #158
Merged
Conversation
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Moves keystone_ui off the old
TheLocal.registercompanion and onto the current manifest-based provider model, and clears out the dead code the migration surfaced.the_local
Depends on the released the_local 0.4.0 (
~> 0.4), the first published version carrying the manifest model.The gem carries no Ruby for the_local anymore. Deleted
KeystoneUi::Companion(lib/keystone_ui/the_local.rb),KeystoneUi::Reference,lib/keystone_ui/reference/guide.md, the three rendered locals underlib/, both requires (entrypoint + Rakefile), andcompanion_test.rb/reference_test.rb.In their place:
the_local/interface.ymldeclares the public surface — 2 install entry points (bin/rails generate keystone:install,KeystoneUi.configure) and 49 develop (all 48ui_*helpers plusKeystone::Ui::Column) — andrake the_local:authorrenderedthe_local/agents/keystone_ui-{info,install,develop}.mdfrom it.rake the_local:checkpasses.The manifest's
sources:lists the component classes, not just the helper file: everyui_*helper is a**argspass-through, so the parameter contract only exists in each component'sinitialize.Dead code removed
keystone:inject_source/keystone:clean_source(lib/tasks/keystone_ui.rake) — they rewrite the/* keystone:source */marker thatinstall_generator.rb:49calls "legacy" and strips on install. Nothing under~/projectsreferenced them. This closes the open question inPLAN.md§5.KeystoneUi::Current—accent_override/surface_overridereferenced by nothing in the gem or inkeystone_colors, which usesKeystoneUiHelperinstead.bundle exec rspecin the docs —CLAUDE.mdandCONTRIBUTING.mddocumented a test framework this repo doesn't use; the suite is Minitest.Guards
test/keystone_ui/packaging_test.rbasserts the committed locals ship —spec.filesneededthe_local/**/*or the gem contributes nothing. Verified red before the fix.localsCI job runsrake the_local:check, so a manifest/local drift fails the build.423 runs, 0 failures. Rubocop clean.
🤖 Generated with Claude Code