Cap view_component below the next major - #160
Merged
Merged
Conversation
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
spec.add_dependency "view_component", ">= 2.0"was open-ended —gem buildwarns about it, and a future ViewComponent 5 with breaking changes would resolve and break installs.Now
">= 2.0", "< 5".Why
< 5and not< 4: the lock already resolves view_component 4.9.0, and the suite passes against it. A< 4cap would have broken the current dev environment.test/keystone_ui/packaging_test.rbasserts the requirement rejects5.0.0, so the bound can't quietly go open-ended again. Verified red before the gemspec change.Folded into 0.6.0's CHANGELOG rather than
[Unreleased]— 0.6.0 hasn't been pushed to RubyGems yet, and this changes what that release will contain.424 runs, 0 failures. Rubocop clean.
bundle installstill resolves 4.9.0.🤖 Generated with Claude Code