Package the MIT license with the gem - #162
Merged
Merged
Conversation
spec.license declared MIT but spec.files globbed only lib, app, config, and the_local, so the license text never shipped. Renames LICENSE to MIT-LICENSE to match the other gems and adds it to spec.files. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
spec.license = "MIT"was declared, butspec.filesglobbed onlylib/,app/,config/, andthe_local/— so the license text was never included in the built gem. keystone_ui 0.6.0 is on RubyGems right now without its license file.Found while checking license conventions across the org after the
keystone_ui-colorsrename.Changes
LICENSE→MIT-LICENSE(git mv), matching the convention the other gems use"MIT-LICENSE"tospec.filesThe copyright line itself is unchanged:
Copyright (c) 2026 Tyler Schneider.Verification
spec.files), passes aftergem buildconfirmsMIT-LICENSEis now in the packaged file listWorth a patch release so the published gem carries its license.
Related
Three other org repos have no license file at all (
event_engine-sourced,-telemetry,-user_events), andevent_engine-coordinatorstill ships the generator placeholderCopyright TODO: Write your name. Not touched here.🤖 Generated with Claude Code